linux-kernel - [tip: irq/core] genirq: Fix inverted condition in handle_nested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <174681655962.406.11707812475471138588.tip-bot2@tip-bot2>
Date: Fri, 09 May 2025 18:49:19 -0000
From: "tip-bot2 for Thomas Gleixner" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Marek Szyprowski <m.szyprowski@...sung.com>,
 Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org,
 linux-kernel@...r.kernel.org, maz@...nel.org
Subject: [tip: irq/core] genirq: Fix inverted condition in handle_nested_irq()

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     c1ab449df871d6ce9189cb0a9efcd37d2ead10f0
Gitweb:        https://git.kernel.org/tip/c1ab449df871d6ce9189cb0a9efcd37d2ead10f0
Author:        Thomas Gleixner <tglx@...utronix.de>
AuthorDate:    Fri, 09 May 2025 20:37:54 +02:00
Committer:     Thomas Gleixner <tglx@...utronix.de>
CommitterDate: Fri, 09 May 2025 20:42:26 +02:00

genirq: Fix inverted condition in handle_nested_irq()

Marek reported that the rework of handle_nested_irq() introduced a inverted
condition, which prevents handling of interrupts. Fix it up.

Fixes: 2ef2e13094c7 ("genirq/chip: Rework handle_nested_irq()")
Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Closes: https://lore.kernel/org/all/46ed4040-ca11-4157-8bd7-13c04c113734@samsung.com
---
 kernel/irq/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 865cf74..1d45c84 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -497,7 +497,7 @@ void handle_nested_irq(unsigned int irq)
 	might_sleep();
 
 	scoped_guard(raw_spinlock_irq, &desc->lock) {
-		if (irq_can_handle_actions(desc))
+		if (!irq_can_handle_actions(desc))
 			return;
 
 		action = desc->action;