linux-kernel - Re: [PATCH 1/3] selftests/timens: Print TAP headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8bf3665-1c3c-4742-a435-a0ef6914dfd4@linuxfoundation.org>
Date: Fri, 9 May 2025 12:53:24 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Shuah Khan <shuah@...nel.org>, "Bird, Timothy" <Tim.Bird@...y.com>,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 Kees Cook <kees@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 1/3] selftests/timens: Print TAP headers

On 5/9/25 09:41, Thomas Weißschuh wrote:
> +Cc Kees
> 
> On Wed, May 07, 2025 at 03:06:16PM -0600, Shuah Khan wrote:
>> On 5/2/25 06:03, Thomas Weißschuh wrote:
>>> The TAP specification requires that the output begins with a header line.
>>> These headers lines are missing in the timens tests.
>>>
>>> Print such a line.
>>
>> There is no cover letter for this - so I will respond to the first
>> patch.
> 
> Hm, I sent one and can also see it on lore.
> 
>> The TAP information is added by the kselftest wrapper if
>> you were to run the test using ksefltest.
>>
>> The following will add the TAP header or if you use make kselftest
>> command from the main Makefile.
>>
>> make -C timens run_tests
>>
>> cd timens; make run_tests (will also add TAP header)
>>
>> The only time you won't see the TAP headers is when you run the test
>> from the test directory just as a command. Is this what you need
>> to do? I would rather not see TAP headers added to invidual tests
>> unless there is a good reason for it.
> 
> Yes, I am running each test on its own, as part of kunit based on [0].
> I also looked at the vDSO selftests and those all print the TAP headers on
> their own. The same for all of the x86 selftests I looked at.

We have been a bit inconsistent with adding TAP headers to individual
tests. We added them to some and then when we found out the nesting
TAP headers issue, we stopped and never really cleaned up.

Since we have this kunit use-case, I am going to take this series
and see who complains. I don't think parsers are in the mix at least
for majority of ksefltest runs.

thanks,
-- Shuah