linux-kernel - Re: [PATCH 1/4] dt-bindings: pinctrl: Document Tegra186 pin controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALHNRZ-QFhrU+=nfN+BFjCe6gDzpE74sPtdofZjC7B3fmoyXVw@mail.gmail.com>
Date: Fri, 9 May 2025 14:46:49 -0500
From: Aaron Kling <webgeek1234@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Linus Walleij <linus.walleij@...aro.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Thierry Reding <thierry.reding@...il.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-tegra@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: Document Tegra186 pin controllers

On Fri, May 9, 2025 at 2:22 PM Rob Herring <robh@...nel.org> wrote:
>
> On Tue, Apr 29, 2025 at 04:33:30PM -0500, Aaron Kling wrote:
> > Tegra186 contains two pin controllers. Document their compatible strings
> > and describe the list of pins and functions that they provide.
> >
> > Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> > ---
> >  .../bindings/pinctrl/nvidia,tegra186-pinmux.yaml   | 285 +++++++++++++++++++++
> >  1 file changed, 285 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra186-pinmux.yaml b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra186-pinmux.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..2fcf42869d7b68671ae3ce78bd33787901ae9203
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra186-pinmux.yaml
> > @@ -0,0 +1,285 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pinctrl/nvidia,tegra186-pinmux.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NVIDIA Tegra186 Pinmux Controller
> > +
> > +maintainers:
> > +  - Thierry Reding <thierry.reding@...il.com>
> > +  - Jon Hunter <jonathanh@...dia.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nvidia,tegra186-pinmux
> > +      - nvidia,tegra186-pinmux-aon
> > +
> > +  reg:
> > +    items:
> > +      - description: pinmux registers
> > +
> > +patternProperties:
> > +  "^pinmux(-[a-z0-9-_]+)?$":
>
> Is there really a case for having just 'pinmux'? Seems like there would
> always be multiple nodes.

This is copied from the existing tegra194 bindings [0] and every
generation of tegra pinctrl bindings that currently exist supports the
name pinmux without a suffix. My hope was not deviate from the other
tegra archs and if or when updates are needed, they can be applied to
all generations in followup patches.

> Don't use '_' in node names.

Will fix in the next revision. Now that I look, Tegra234 already
restricted this, but I copied from Tegra194.

>
> > +    type: object
> > +
> > +    # pin groups
> > +    additionalProperties:
>
> Define a node name pattern here instead. Allowing any name was for
> existing bindings.

All existing tegra generations allow any name, and I don't see any
pattern that could be defined based on the existing examples and
usages. I'd again like to not deviate from the other archs, for ease
of concurrent upkeep. But if it has to, what should the pattern be?

Sincerely,
Aaron

[0] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/pinctrl/nvidia%2Ctegra194-pinmux.yaml