linux-kernel - Re: [PATCH] kunit: configs: Enable coverage of the bitfield packing library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+GJov6vfs=tdWW_F5mkin+EDAft+j9CK=5kHcOf11MufOFdvA@mail.gmail.com>
Date: Fri, 9 May 2025 15:47:08 -0400
From: Rae Moar <rmoar@...gle.com>
To: Mark Brown <broonie@...nel.org>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kunit: configs: Enable coverage of the bitfield packing library

On Fri, Apr 25, 2025 at 6:19 PM Mark Brown <broonie@...nel.org> wrote:
>
> There are KUnit tests for the bitfield packing library but these depend
> on CONFIG_PACKING which is not enabled by anything in either the
> existing KUnit all_tests.config or the base UML config it runs on as
> standard.  Enable that in all_tests.config to improve coverage.
>
> Signed-off-by: Mark Brown <broonie@...nel.org>

Hello,

This looks good to me. It adds about 70 tests to the "alltests" run.
They all seem to pass and run fast so I am happy to add this.

Reviewed-by: Rae Moar <rmoar@...gle.com>

Thanks!
-Rae

> ---
>  tools/testing/kunit/configs/all_tests.config | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config
> index cdd9782f9646..b0223b7aebde 100644
> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config
> @@ -51,3 +51,5 @@ CONFIG_SOUND=y
>  CONFIG_SND=y
>  CONFIG_SND_SOC=y
>  CONFIG_SND_SOC_TOPOLOGY_BUILD=y
> +
> +CONFIG_PACKING=y
>
> ---
> base-commit: 8ffd015db85fea3e15a77027fda6c02ced4d2444
> change-id: 20250422-kunit-enable-missing-tests-9189ee930cae
>
> Best regards,
> --
> Mark Brown <broonie@...nel.org>
>