[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250509155412.03c89196@gandalf.local.home>
Date: Fri, 9 May 2025 15:54:12 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Vincent Donnefort <vdonnefort@...gle.com>
Cc: mhiramat@...nel.org, mathieu.desnoyers@...icios.com,
linux-trace-kernel@...r.kernel.org, maz@...nel.org, oliver.upton@...ux.dev,
joey.gouly@....com, suzuki.poulose@....com, yuzenghui@...wei.com,
kvmarm@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
jstultz@...gle.com, qperret@...gle.com, will@...nel.org,
kernel-team@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 08/24] ring-buffer: Expose buffer_data_page material
On Tue, 6 May 2025 17:48:04 +0100
Vincent Donnefort <vdonnefort@...gle.com> wrote:
> In preparation for allowing the write of ring-buffer compliant pages
> outside of ring_buffer.c, move buffer_data_page and timestamps
> encoding functions into the publicly available ring_buffer.h.
>
> Signed-off-by: Vincent Donnefort <vdonnefort@...gle.com>
Let's create a new file for this instead of adding it to ring_buffer.h.
Although it's being used by remote buffers, I rather not make this
something that people may think they can access anywhere.
Perhaps: ring_buffer_types.h
with a comment stating that these are to be used by the remote ring buffers
and the ring buffer internals and should not be used directly.
-- Steve
Powered by blists - more mailing lists