linux-kernel - Re: [PATCH v2 0/6] Use rustc-demangle for Rust demangling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aB5fog7c-Ucs6dAN@x1>
Date: Fri, 9 May 2025 17:03:46 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	James Clark <james.clark@...aro.org>,
	Howard Chu <howardchu95@...il.com>,
	Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	Ravi Bangoria <ravi.bangoria@....com>,
	"Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
	Stephen Brennan <stephen.s.brennan@...cle.com>,
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
	rust-for-linux@...r.kernel.org, llvm@...ts.linux.dev,
	Daniel Xu <dxu@...uu.xyz>, Ariel Ben-Yehuda <ariel.byd@...il.com>
Subject: Re: [PATCH v2 0/6] Use rustc-demangle for Rust demangling

On Tue, Apr 29, 2025 at 05:41:22PM -0700, Ian Rogers wrote:
> Discussion of improved Rust demangling started with:
> https://lore.kernel.org/lkml/jgxfnphfo3nzlfipnuuzdlfc4ehbr2tnh2evz3mdhynd6wvrsu@fcz6vrvepybb/
> that led to implementing a Rust v0 demangler:
> https://lore.kernel.org/lkml/20250129193037.573431-1-irogers@google.com/
> Discussion on that patch series led to the rust-lang issue:
> https://github.com/rust-lang/rust/issues/60705
> where the pre-existing Rust C demangler, authored by Ariel Ben-Yehuda
>  <ariel.byd@...il.com>, was mentioned. There wasn't progress on that
> issue and so I've pulled that work into perf as discussed on the
> issue.
> 
> v2: Changes to references from arielb1 to "Ariel Ben Yehuda
>     <ariel.byd@...il.com>", license tidying as suggested by Miguel
>     Ojeda" <ojeda@...nel.org>. Don't change from alternate demangling
>     flag from false to true in the test change, make it true from the
>     beginning (patch 2).
> 
> Ian Rogers (6):
>   perf demangle-rust: Add rustc-demangle C demangler
>   perf symbol-elf: Integrate rust-v0 demangling
>   perf demangle-rust: Remove previous legacy rust decoder
>   perf test demangle-rust: Add Rust demangling test
>   perf test demangle-java: Switch to using dso__demangle_sym
>   perf test demangle-ocaml: Switch to using dso__demangle_sym

I'm fixing these up, ok?

  ✗ BADSIG: DKIM/google.com
---
Total patches: 6
---
Cover: ./v2_20250429_irogers_use_rustc_demangle_for_rust_demangling.cover
 Link: https://lore.kernel.org/r/20250430004128.474388-1-irogers@google.com
 Base: applies clean to current tree
       git checkout -b v2_20250429_irogers_google_com HEAD
       git am ./v2_20250429_irogers_use_rustc_demangle_for_rust_demangling.mbx
⬢ [acme@...lbx perf-tools-next]$        git am ./v2_20250429_irogers_use_rustc_demangle_for_rust_demangling.mbx
Applying: perf demangle-rust: Add rustc-demangle C demangler
.git/rebase-apply/patch:1098: trailing whitespace.
    
.git/rebase-apply/patch:1363: trailing whitespace.
    
.git/rebase-apply/patch:1474: trailing whitespace.
    default: 
.git/rebase-apply/patch:1791: trailing whitespace.
        { NULL }, 
.git/rebase-apply/patch:1814: trailing whitespace.
        // From here on, inner contains a pointer to the next element, rest[:len] to the current one        
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.
Applying: perf symbol-elf: Integrate rust-v0 demangling
Applying: perf demangle-rust: Remove previous legacy rust decoder
Applying: perf test demangle-rust: Add Rust demangling test
Applying: perf test demangle-java: Switch to using dso__demangle_sym
Applying: perf test demangle-ocaml: Switch to using dso__demangle_sym
⬢ [acme@...lbx perf-tools-next]$

Applied.

- Arnaldo