linux-kernel - Re: [PATCH v2 5/5] dt-bindings: hwmon: Add bindings for mpq8785 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <606a3d9a-857a-4fd6-a9b9-76a9c8d60cea@kernel.org>
Date: Fri, 9 May 2025 09:00:39 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pawel Dembicki <paweldembicki@...il.com>, linux-hwmon@...r.kernel.org
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>,
 Noah Wang <noahwang.wang@...look.com>, Michal Simek <michal.simek@....com>,
 Fabio Estevam <festevam@...il.com>,
 Naresh Solanki <naresh.solanki@...ements.com>,
 Grant Peltier <grantpeltier93@...il.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Greg KH <gregkh@...uxfoundation.org>, Peter Zijlstra <peterz@...radead.org>,
 Shen Lichuan <shenlichuan@...o.com>, Charles Hsu <ythsu0511@...il.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 5/5] dt-bindings: hwmon: Add bindings for mpq8785
 driver

On 09/05/2025 08:51, Pawel Dembicki wrote:
> Add device tree bindings for Monolithic Power Systems MPQ8785, MPM82504
> and MPM3695 PMBus-compliant voltage regulators.
> 
> These bindings also documents the optional
> "mps,vout-fb-divider-ratio-permille" property.
> 
> ---
> v2:
>   - remove mps,mpq8785 from trivial-devices.yaml
>   - fix alphabetical order
>   - rename voltage-scale-loop to mps,vout-fb-divider-ratio-permille
>   - add mps,vout-fb-divider-ratio-permille min and max values
>   - rewrite mps,vout-fb-divider-ratio-permille description

If you are going to send a new version, then reorder the patches so the
bindings are before the user (see submitting patches in DT doc dir).

> 
> Signed-off-by: Pawel Dembicki <paweldembicki@...il.com>
> ---
>  .../bindings/hwmon/pmbus/mps,mpq8785.yaml     | 88 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |  2 -
>  2 files changed, 88 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> new file mode 100644
> index 000000000000..3c61f5484326
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/pmbus/mps,mpq8785.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Monolithic Power Systems Multiphase Voltage Regulators with PMBus
> +
> +maintainers:
> +  - Charles Hsu <ythsu0511@...il.com>
> +
> +description:
> +  Monolithic Power Systems digital multiphase voltage regulators with PMBus.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - mps,mpm3695
> +      - mps,mpm3695-25
> +      - mps,mpm82504
> +      - mps,mpq8785
> +
> +  reg:
> +    maxItems: 1
> +
> +  mps,vout-fb-divider-ratio-permille:
> +    description:
> +      The feedback resistor divider ratio, expressed in permille
> +      (Vfb / Vout * 1000). This value is written to the PMBUS_VOUT_SCALE_LOOP
> +      register and is required for correct output voltage presentation.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1

maximum: 4095
default: X

required: block goes here, before allOf: block.

> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: mps,mpq8785
> +    then:
> +      properties:
> +        mps,vout-fb-divider-ratio-permille:
> +          maximum: 2047
> +
> +  - if:
> +      properties:
> +        compatible:
> +          const: mps,mpm82504

That's enum with mpm3695

> +    then:
> +      properties:
> +        mps,vout-fb-divider-ratio-permille:
> +          maximum: 1023
> +
Best regards,
Krzysztof