linux-kernel - Re: [PATCH v2 1/4] extcon: adc-jack: Fix wakeup source leaks on device unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1cd209e0-bdfa-49f0-8430-fec7e6108f35@linaro.org>
Date: Fri, 9 May 2025 09:12:59 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi
 <cw00.choi@...sung.com>, Hans de Goede <hdegoede@...hat.com>,
 Chen-Yu Tsai <wens@...e.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 1/4] extcon: adc-jack: Fix wakeup source leaks on
 device unbind

On 09/05/2025 08:20, Christophe JAILLET wrote:
>>   drivers/extcon/extcon-adc-jack.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
>> index 46c40d85c2ac89599ffbe7b6d11b161b295d5564..557930394abd25771799733a22121d1f8e254918 100644
>> --- a/drivers/extcon/extcon-adc-jack.c
>> +++ b/drivers/extcon/extcon-adc-jack.c
>> @@ -164,6 +164,7 @@ static void adc_jack_remove(struct platform_device *pdev)
>>   {
>>   	struct adc_jack_data *data = platform_get_drvdata(pdev);
>>   
>> +	device_init_wakeup(&pdev->dev, false);
> 
> Hi,
> 
> Shouldn't this be:
> 
> 	if (data->wakeup_source)
> 		device_init_wakeup(&pdev->dev, false);
> 
> to match how things are done in the probe?

Yes, it should. I'll fix it.

Best regards,
Krzysztof