linux-kernel - Re: [PATCH v1] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d91f6f10-a17e-4bbc-94a1-41b43b41c1ec@redhat.com>
Date: Fri, 9 May 2025 09:33:38 +0200
From: David Hildenbrand <david@...hat.com>
To: Dev Jain <dev.jain@....com>, linux-kernel@...r.kernel.org
Cc: linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>, Shuah Khan <shuah@...nel.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, Ingo Molnar
 <mingo@...hat.com>, Peter Xu <peterx@...hat.com>
Subject: Re: [PATCH v1] selftests/mm: add simple VM_PFNMAP tests based on
 mmap'ing /dev/mem

On 09.05.25 07:35, Dev Jain wrote:
> 
> 
> On 09/05/25 3:50 am, David Hildenbrand wrote:
>> Let's test some basic functionality using /dev/mem. These tests will
>> implicitly cover some PAT (Page Attribute Handling) handling on x86.
>>
>> These tests will only run when /dev/mem access to the first two pages
>> in physical address space is possible and allowed; otherwise, the tests
>> are skipped.
> 

Hi Dev,

> Some generic comments:
> 1. I think you should also update .gitignore?

I wonder if we could add a checkpatch warning for that, it keeps on 
happening :)

> 2. You can use ksft_exit_fail_perror() for wherever you want to print
> strerror(errno).


Makes sense, thanks!


-- 
Cheers,

David / dhildenb