linux-kernel - Re: [PATCH v2 2/5] dt-bindings: phy: rockchip: naneng-combphy: Add RK3528 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aB2wjKa1D832FKBH@pie.lan>
Date: Fri, 9 May 2025 07:37:17 +0000
From: Yao Zi <ziyao@...root.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>,
	Kishon Vijay Abraham I <kishon@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Frank Wang <frank.wang@...k-chips.com>,
	Andy Yan <andy.yan@...k-chips.com>,
	Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
	Detlev Casanova <detlev.casanova@...labora.com>,
	Shresth Prasad <shresthprasad7@...il.com>,
	Chukun Pan <amadeus@....edu.cn>, Jonas Karlman <jonas@...boo.se>,
	linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v2 2/5] dt-bindings: phy: rockchip: naneng-combphy: Add
 RK3528 variant

On Fri, May 09, 2025 at 08:03:11AM +0200, Krzysztof Kozlowski wrote:
> On Fri, May 09, 2025 at 12:41:19AM GMT, Yao Zi wrote:
> > Rockchip RK3528 ships one naneng-combphy which operates in either PCIe
> > or USB 3 mode. Document its compatible string.
> > 
> > Signed-off-by: Yao Zi <ziyao@...root.org>
> > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> > Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> > ---
> 
> Eh, no...
> 
> >  .../devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> > index 888e6b2aac5a..bd064754e537 100644
> > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> > @@ -12,6 +12,7 @@ maintainers:
> >  properties:
> >    compatible:
> >      enum:
> > +      - rockchip,rk3528-naneng-combphy
> >        - rockchip,rk3562-naneng-combphy
> >        - rockchip,rk3568-naneng-combphy
> >        - rockchip,rk3576-naneng-combphy
> > @@ -102,7 +103,9 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: rockchip,rk3588-naneng-combphy
> > +            enum:
> > +             - rockchip,rk3528-naneng-combphy
> 
> Still not tested. Neither v1 nor v2 was ever tested.

Oops, somehow I missed warnings about the indentation...

Thanks for pointing out, I'll drop the tags, wait until the prerequsite
series get merged and send v3 with this problem fixed.

> Best regards,
> Krzysztof
> 

Thanks,
Yao Zi