linux-kernel - Re: [PATCH v6 5/8] selftests: ublk: kublk: lift queue initialization out of thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aB2yU5HUYtmKFzol@fedora>
Date: Fri, 9 May 2025 15:44:19 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Uday Shankar <ushankar@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>,
	Caleb Sander Mateos <csander@...estorage.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Shuah Khan <shuah@...nel.org>, Jonathan Corbet <corbet@....net>,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v6 5/8] selftests: ublk: kublk: lift queue initialization
 out of thread

On Wed, May 07, 2025 at 03:49:39PM -0600, Uday Shankar wrote:
> Currently, each ublk server I/O handler thread initializes its own
> queue. However, as we move towards decoupled ublk_queues and ublk server
> threads, this model does not make sense anymore, as there will no longer
> be a concept of a thread having "its own" queue. So lift queue
> initialization out of the per-thread ublk_io_handler_fn and into a loop
> in ublk_start_daemon (which runs once for each device).
> 
> There is a part of ublk_queue_init (ring initialization) which does
> actually need to happen on the thread that will use the ring; that is
> separated into a separate ublk_thread_init which is still called by each
> I/O handler thread.
> 
> Signed-off-by: Uday Shankar <ushankar@...estorage.com>

Reviewed-by: Ming Lei <ming.lei@...hat.com>


thanks,
Ming