linux-kernel - Re: [PATCH net-next v3] xdp: Add helpers for head length, headroom, and metadata length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250508182607.75993cf3@kernel.org>
Date: Thu, 8 May 2025 18:26:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jesper Dangaard Brouer <hawk@...nel.org>
Cc: Jon Kohler <jon@...anix.com>, Willem de Bruijn
 <willemdebruijn.kernel@...il.com>, Zvi Effron <zeffron@...tgames.com>,
 Stanislav Fomichev <stfomichev@...il.com>, Jason Wang
 <jasowang@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, John Fastabend <john.fastabend@...il.com>,
 Simon Horman <horms@...nel.org>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "bpf@...r.kernel.org"
 <bpf@...r.kernel.org>, Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH net-next v3] xdp: Add helpers for head length, headroom,
 and metadata length

On Thu, 8 May 2025 18:59:54 +0200 Jesper Dangaard Brouer wrote:
> I do notice Jakub isn't a fan of the patch in general, but it seems
> quite popular given the other high profile kernel developers that acked
> in V3.  I think it increase code readability for people that are less
> familiar with XDP code and meaning of the pointers (e.g. data_hard_start
> vs. data_end vs. data vs. data_meta). (We don't even have some ascii art
> showing these pointers).

Yup, ASCII art would be great, hopefully

 DOC: Basic sk_buff geometry

can be an inspiration.