linux-kernel - Re: [PATCH v2] arm64: dts: ti: k3-j721e-common-proc-board: Enable OSPI1 on J721E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250509082509.ogfs2ulyfgk6etxc@unshaved>
Date: Fri, 9 May 2025 03:25:09 -0500
From: Nishanth Menon <nm@...com>
To: Prasanth Babu Mantena <p-mantena@...com>
CC: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <vigneshr@...com>, <kristo@...nel.org>, <robh@...nel.org>,
        <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>, <u-kumar1@...com>
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721e-common-proc-board: Enable
 OSPI1 on J721E

On 10:37-20250507, Prasanth Babu Mantena wrote:
> J721E SoM has MT25QU512AB Serial NOR flash connected to
> OSPI1 controller. Enable ospi1 node in device tree.
>
> Fixes: cb27354b38f3b ("arm64: dts: ti: k3-j721e: Add DT nodes for few peripherials")

Yes, cb27354b38f3b ("arm64: dts: ti: k3-j721e: Add DT nodes for few
peripherials") did not enable the node, But back then, we used to
ensure all nodes were left default (okay) and then disable unused
nodes in board dts.

BUT, we ended up having a bunch of maintenance issues and board bring
up problems and looking at the rest of the ARM ecosystems (you can
check the mailing list for all the discussions on the topic), we
flipped the order for peripherals that need board level connectivity
for functionality to be disabled in SoC.dtsi and enabled explicitly at
board level and when that occurred, specifically:
73676c480b72 ("arm64: dts: ti: k3-j721e: Enable OSPI nodes at the board
level") which enabled ospi0 at SoM level, but missed fixing this up,
whoops!

I will fix this up locally when I apply this patch. but FYI.

> Signed-off-by: Prasanth Babu Mantena <p-mantena@...com>
> ---
> Test log : https://gist.github.com/PrasanthBabuMantena/9dda540dce88282117de7e0e945e24ca
>  arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index e3d0ef6913b2..45311438315f 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -573,6 +573,7 @@ &usb1 {
>  &ospi1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&mcu_fss0_ospi1_pins_default>;
> +	status = "okay";
>
>  	flash@0 {
>  		compatible = "jedec,spi-nor";
> --
> 2.34.1
>
>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D