linux-kernel - Re: [PATCH] i.MX8 ISI crossbar: simplify a couple of error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250509091549.GD28896@pendragon.ideasonboard.com>
Date: Fri, 9 May 2025 11:15:49 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Krzysztof Hałasa <khalasa@...p.pl>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-media@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i.MX8 ISI crossbar: simplify a couple of error messages

Hi Krzysztof,

On Fri, May 09, 2025 at 09:58:09AM +0200, Krzysztof Hałasa wrote:
> I guess these messages were split from a single function. Or was it
> for saving memory? :-)

The goal was indeed to save memory.

> Signed-off-by: Krzysztof Hałasa <khalasa@...p.pl>
> 
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> index 93a55c97cd17..b6c7f114f9ed 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c
> @@ -352,9 +352,8 @@ static int mxc_isi_crossbar_enable_streams(struct v4l2_subdev *sd,
>  						 sink_streams);
>  		if (ret) {
>  			dev_err(xbar->isi->dev,
> -				"failed to %s streams 0x%llx on '%s':%u: %d\n",
> -				"enable", sink_streams, remote_sd->name,
> -				remote_pad, ret);
> +				"failed to enable streams 0x%llx on '%s':%u: %d\n",
> +				sink_streams, remote_sd->name, remote_pad, ret);
>  			mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
>  			return ret;
>  		}
> @@ -392,9 +391,8 @@ static int mxc_isi_crossbar_disable_streams(struct v4l2_subdev *sd,
>  						  sink_streams);
>  		if (ret)
>  			dev_err(xbar->isi->dev,
> -				"failed to %s streams 0x%llx on '%s':%u: %d\n",
> -				"disable", sink_streams, remote_sd->name,
> -				remote_pad, ret);
> +				"failed to disable streams 0x%llx on '%s':%u: %d\n",
> +				sink_streams, remote_sd->name, remote_pad, ret);
>  
>  		mxc_isi_crossbar_gasket_disable(xbar, sink_pad);
>  	}

-- 
Regards,

Laurent Pinchart