linux-kernel - Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c0a3b62-cf4f-46ec-b0e2-7d78ac499cb5@kernel.org>
Date: Fri, 9 May 2025 11:21:32 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chaoyi Chen <chaoyi.chen@...k-chips.com>, Chaoyi Chen
 <kernel@...kyi.com>, Sandy Huang <hjc@...k-chips.com>,
 Heiko Stuebner <heiko@...ech.de>, Andy Yan <andy.yan@...k-chips.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: Dragan Simic <dsimic@...jaro.org>, dri-devel@...ts.freedesktop.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert
 cdn-dp-rockchip.txt to yaml

On 09/05/2025 09:34, Chaoyi Chen wrote:
> Hi Krzysztof,
> 
> On 2025/5/9 15:11, Krzysztof Kozlowski wrote:
>> On 09/05/2025 09:02, Chaoyi Chen wrote:
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: core-clk
>>> +      - const: pclk
>>> +      - const: spdif
>>> +      - const: grf
>>> +
>>> +  extcon:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>>> +    description:
>>> +      Phandle to the extcon device providing the cable state for the DP PHY.
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  phys:
>>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>> Just phandle. If this is an array (but why?), you need maxItems for
>> outer and inner dimensions.

Uh, sorry, that was supposed to be under extcon.

> 
> I think it could be phandle or phandle-array. Since the RK3399 DP has 

Here it is obviously not needed, that's a dtschema type.

> two PHYs, if we put in two PHYs here, the driver will pick one PHY port 
> that is already plugged into the DP for output. If we fill in only one 
> PHY here, then output is only allowed on the corresponding PHY.
> 
> Will add restrictions and add more descriptions in v3.
> 
> 
>>
>>> +    description:
>>> +      Phandle to the PHY device for DP output.

You need to list the items with description iinstead.



Best regards,
Krzysztof