linux-kernel - Re: [PATCH net v2] fddi: skfp: fix null pointer deferenece in smt.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250508192758.0bf5014e@kernel.org>
Date: Thu, 8 May 2025 19:27:58 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Siddarth Gundu <siddarthsgml@...il.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org
Subject: Re: [PATCH net v2] fddi: skfp: fix null pointer deferenece in smt.c

On Thu,  8 May 2025 02:07:06 +0530 Siddarth Gundu wrote:
> In smt_string_swap(), when a closing bracket ']' is encountered
> before any opening bracket '[' open_paren would be NULL,
> and assigning it to format would lead to a null pointer being
> dereferenced in the format++ statement.
> 
> Add a check to verify open_paren is non-NULL before assigning
> it to format

You'd have to explain where an invalid format could come from.
As far as I can tell they are all hardcoded (grep for SWAP_SMT)
-- 
pw-bot: cr