| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <D9RL9DZN7PXS.PGSNWKK9J548@cknow.org>
Date: Fri, 09 May 2025 13:21:13 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Heiko Stuebner" <heiko@...ech.de>
Cc: <quentin.schulz@...rry.de>, <robh@...nel.org>, <krzk+dt@...nel.org>,
<conor+dt@...nel.org>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-rockchip@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
"Heiko Stuebner" <heiko.stuebner@...rry.de>
Subject: Re: [PATCH 4/6] arm64: dts: rockchip: add px30-cobra base dtsi and
board variants
Hi,
On Thu May 8, 2025 at 5:09 PM CEST, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@...rry.de>
>
> Cobra are Touchscreen devices built around the PX30 SoC using
> a variety of display options.
>
> The devices feature an EMMC, network port, usb host + OTG ports and
> a 720x1280 display with a touchscreen.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@...rry.de>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 4 +
> .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 39 ++
> .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 39 ++
> .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 39 ++
> .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 58 ++
> arch/arm64/boot/dts/rockchip/px30-cobra.dtsi | 570 ++++++++++++++++++
> 6 files changed, 749 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w-a2.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3146w.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk050h3148w.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra-ltk500hd1829.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/px30-cobra.dtsi
>
> <snip>
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi b/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi
> new file mode 100644
> index 000000000000..92066cbc1a70
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/px30-cobra.dtsi
> @@ -0,0 +1,570 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2025 Cherry Embedded Solutions GmbH
> + */
> +
> +/dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include "px30.dtsi"
> +
> +/ {
> + aliases {
> + mmc0 = &emmc;
> + };
> +
> + chosen {
> + stdout-path = "serial5:115200n8";
> + };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + power-supply = <&vcc5v0_sys>;
> + pwms = <&pwm0 0 25000 0>;
> + };
> +
> + beeper {
> + compatible = "pwm-beeper";
> + pwms = <&pwm1 0 1000 0>;
> + };
> +
> + emmc_pwrseq: emmc-pwrseq {
> + compatible = "mmc-pwrseq-emmc";
> + pinctrl-0 = <&emmc_reset>;
> + pinctrl-names = "default";
> + reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_HIGH>;
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + led-0 {
> + color = <LED_COLOR_ID_BLUE>;
> + gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>;
> + label = "heartbeat";
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> + pwm-leds {
> + compatible = "pwm-leds";
> +
> + ring_red: led-0 {
> + color = <LED_COLOR_ID_RED>;
> + default-state = "off";
> + label = "ring_red";
> + pwms = <&pwm5 0 1000000 0>;
> + max-brightness = <255>;
> + };
> +
> + ring_green: led-1 {
> + color = <LED_COLOR_ID_GREEN>;
> + default-state = "off";
> + label = "ring_green";
> + pwms = <&pwm6 0 1000000 0>;
> + max-brightness = <255>;
> + };
> +
> + ring_blue: led-2 {
> + color = <LED_COLOR_ID_BLUE>;
> + default-state = "off";
> + label = "ring_blue";
> + pwms = <&pwm7 0 1000000 0>;
> + max-brightness = <255>;
> + };
> + };
> +
> + /* also named 5V_Q7 in schematics */
> + vcc5v0_sys: regulator-vccsys {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_sys";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +};
> +
> +&cpu0 {
> + cpu-supply = <&vdd_arm>;
> +};
> +
> +&cpu1 {
> + cpu-supply = <&vdd_arm>;
> +};
> +
> +&cpu2 {
> + cpu-supply = <&vdd_arm>;
> +};
> +
> +&cpu3 {
> + cpu-supply = <&vdd_arm>;
> +};
> +
> +&display_subsystem {
> + status = "okay";
> +};
> +
> +&dsi_dphy {
> + status = "okay";
> +};
> +
> +&emmc {
> + bus-width = <8>;
> + cap-mmc-highspeed;
> + /*
> + * For hs200 support, U-Boot would have to set the RK809 DCDC4
> + * rail to 1.8V from the default of 3.0V. It doesn't do that on
> + * devices out in the field, so disable hs200.
> + * mmc-hs200-1_8v;
> + */
> + mmc-pwrseq = <&emmc_pwrseq>;
> + non-removable;
> + vmmc-supply = <&vcc_3v3>;
> + vqmmc-supply = <&vcc_emmc>;
> + status = "okay";
> +};
> +
> +&gmac {
> + clock_in_out = "output";
> + phy-handle = <&dp83825>;
> + phy-supply = <&vcc_3v3>;
> + status = "okay";
> +};
> +
> +&gpu {
> + mali-supply = <&vdd_log>;
> + status = "okay";
> +};
> +
> +/* I2C0 = PMIC, STUSB4500, RTC */
> +&i2c0 {
> + status = "okay";
> +
> + rk809: pmic@20 {
> + compatible = "rockchip,rk809";
> + reg = <0x20>;
> + #clock-cells = <0>;
> + clock-output-names = "xin32k";
> + interrupt-parent = <&gpio0>;
> + interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pmic_int>;
> + wakeup-source;
> + rockchip,system-power-controller;
The "rockchip," prefix is not needed and deprecated, so you can drop it.
Same issue is present in patch 6 of this series.
Cheers,
Diederik
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists