[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4dbe2a87-2c03-4565-a486-41d4116892ae@linaro.org>
Date: Fri, 9 May 2025 12:26:21 +0100
From: James Clark <james.clark@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: linux-spi@...r.kernel.org, imx@...ts.linux.dev,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Ciprian Marian Costea <ciprianmarian.costea@....com>,
Vladimir Oltean <olteanv@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Frank Li <Frank.Li@....com>,
Chester Lin <chester62515@...il.com>, Matthias Brugger <mbrugger@...e.com>,
Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>,
NXP S32 Linux Team <s32@....com>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, larisa.grigore@....com, arnd@...aro.org,
andrei.stefanescu@....com, dan.carpenter@...aro.org
Subject: Re: [PATCH 12/14] dt-bindings: spi: dspi: Add S32G support
On 09/05/2025 12:14 pm, Krzysztof Kozlowski wrote:
> On 09/05/2025 13:05, James Clark wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@....com>
>>
>> Document S32G compatible strings. 's32g2' and 's32g3' use the same
>> driver so 's32g2' must follow 's32g3'.
>>
>> The SPI controller node in dts can define both host and target pinctrl.
>> The selection between them will be done based on pinctrl-names. The
>> default pinctrl will be loaded first and will be used by the host. If
>> the controller is configured as target (spi-slave property is added in
>> the dts node), the driver will look for the "slave" pinctrl and apply it
>> if found.
>
>
> I do not see any changes in the binding related to above paragraph, so I
> do not understand why are you explaining driver?
>
Yes it's probably a bit verbose, it's just a standard SPI binding that
also supports target mode. I can reduce it.
I'm also not even sure the "slave" pinctrl part is correct as I was
testing it in target mode without any special naming. I will double
check that too.
>>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@....com>
>> Signed-off-by: Larisa Grigore <larisa.grigore@....com>
>> Signed-off-by: James Clark <james.clark@...aro.org>
>> ---
>> Documentation/devicetree/bindings/spi/fsl,dspi.yaml | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/fsl,dspi.yaml b/Documentation/devicetree/bindings/spi/fsl,dspi.yaml
>> index 7ca8fceda717..b5fac0bb142a 100644
>> --- a/Documentation/devicetree/bindings/spi/fsl,dspi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/fsl,dspi.yaml
>> @@ -23,6 +23,7 @@ properties:
>> - fsl,ls2080a-dspi
>> - fsl,ls2085a-dspi
>> - fsl,lx2160a-dspi
>> + - nxp,s32g2-dspi
>> - items:
>> - enum:
>> - fsl,ls1012a-dspi
>> @@ -37,6 +38,9 @@ properties:
>> - items:
>> - const: fsl,lx2160a-dspi
>> - const: fsl,ls2085a-dspi
>> + - items:
>> + - const: nxp,s32g3-dspi
>> + - const: nxp,s32g2-dspi
>>
>> reg:
>> maxItems: 1
>> @@ -114,3 +118,17 @@ examples:
>> spi-cs-hold-delay-ns = <50>;
>> };
>> };
>> + # S32G3 in target mode
>> + - |
>> + spi0: spi@...d4000 {
>
> Drop unused label.
>
Will do.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> Best regards,
> Krzysztof
Thanks for the review.
James
Powered by blists - more mailing lists