linux-kernel - Re: [PATCH 1/1] soc: ti: wkup_m3_ipc: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250509113238.sjj5lj47hh3y4hts@lcpd911>
Date: Fri, 9 May 2025 17:02:38 +0530
From: Dhruva Gole <d-gole@...com>
To: Alexander Stein <alexander.stein@...tq-group.com>
CC: Nishanth Menon <nm@...com>, Santosh Shilimkar <ssantosh@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/1] soc: ti: wkup_m3_ipc: Use dev_err_probe

On May 09, 2025 at 11:36:52 +0200, Alexander Stein wrote:
> During probe the mailbox channel might not yet be available. Use
> dev_err_probe to silence this deferred probe error message:
> wkup_m3_ipc 44e11324.wkup_m3_ipc: IPC Request for A8->M3 Channel failed! -517
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
>  drivers/soc/ti/wkup_m3_ipc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
> index 79dde9a7ec639..5845fc652adcf 100644
> --- a/drivers/soc/ti/wkup_m3_ipc.c
> +++ b/drivers/soc/ti/wkup_m3_ipc.c
> @@ -644,11 +644,9 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev)
>  
>  	m3_ipc->mbox = mbox_request_channel(&m3_ipc->mbox_client, 0);
>  
> -	if (IS_ERR(m3_ipc->mbox)) {
> -		dev_err(dev, "IPC Request for A8->M3 Channel failed! %ld\n",
> -			PTR_ERR(m3_ipc->mbox));
> -		return PTR_ERR(m3_ipc->mbox);
> -	}
> +	if (IS_ERR(m3_ipc->mbox))
> +		return dev_err_probe(dev, PTR_ERR(m3_ipc->mbox),
> +				     "IPC Request for A8->M3 Channel failed!\n");

Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated