linux-kernel - Re: [PATCH] ASPEED: bmc: Add device tree for Meta(Facebook) Clemente compute-tray.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f7b44f0-128c-4615-96cf-2d9d8bc54cdb@linaro.org>
Date: Fri, 9 May 2025 13:36:01 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: leo.jt.wang@...il.com, robh+dt@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, joel@....id.au,
 andrew@...econstruct.com.au, keescook@...omium.org, tony.luck@...el.com,
 gpiccoli@...lia.com, geert+renesas@...der.be, magnus.damm@...il.com,
 linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, george.kw.lee@...-foxconn.com,
 leo.jt.wang@...-foxconn.com
Subject: Re: [PATCH] ASPEED: bmc: Add device tree for Meta(Facebook) Clemente
 compute-tray.

On 09/05/2025 10:59, leo.jt.wang@...il.com wrote:
> From: Leo Wang <leo.jt.wang@...-foxconn.com>
> 
> Signed-off-by: Leo Wang <leo.jt.wang@...-foxconn.com>

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

You CC-ed an address, which suggests you do not work on mainline kernel
or you do not use get_maintainers.pl/b4/patman. Please rebase and always
work on mainline or start using mentioned tools, so correct addresses
will be used.

...

> +&io_expander13 {
> +	gpio-line-names =
> +		"rmc_en_dc_pwr_on","",
> +		"","",
> +		"","",
> +		"","",
> +		"leak_config_0","leak_config_1",
> +		"leak_config_2","leak_config_3",
> +		"mfg_led_test_mode_l","small_leak_err_inj",
> +		"large_leak_err_inj","";
> +};
> \ No newline at end of file

You have patch warning.

Best regards,
Krzysztof