linux-kernel - Re: [PATCH v4 4/6] gpio: fix potential out-of-bound write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MeYYUc=FKJdArpqv0D2fUt1vyCJiZzjYyN95aMv0-b1WA@mail.gmail.com>
Date: Fri, 9 May 2025 14:40:26 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Markus Burri <markus.burri@...com>
Cc: linux-kernel@...r.kernel.org, Mahesh J Salgaonkar <mahesh@...ux.ibm.com>, 
	"Oliver O'Halloran" <oohall@...il.com>, Madhavan Srinivasan <maddy@...ux.ibm.com>, 
	Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>, 
	Christophe Leroy <christophe.leroy@...roup.eu>, Naveen N Rao <naveen@...nel.org>, 
	Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>, 
	Maciej Falkowski <maciej.falkowski@...ux.intel.com>, Oded Gabbay <ogabbay@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Nuno Sa <nuno.sa@...log.com>, 
	Olivier Moysan <olivier.moysan@...s.st.com>, Jonathan Cameron <jic23@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, linuxppc-dev@...ts.ozlabs.org, 
	dri-devel@...ts.freedesktop.org, linux-gpio@...r.kernel.org, 
	linux-iio@...r.kernel.org, Markus Burri <markus.burri@....ch>
Subject: Re: [PATCH v4 4/6] gpio: fix potential out-of-bound write

On Thu, May 8, 2025 at 3:07 PM Markus Burri <markus.burri@...com> wrote:
>
> Check that the input size does not exceed the buffer size.
> If a caller write more characters, count is truncated to the max available
> space in "simple_write_to_buffer".
> Write a zero termination afterwards.
>
> Signed-off-by: Markus Burri <markus.burri@...com>
> ---

Looks good and does fix an issue that can be easily reproduced with
KASAN enabled. Please fix the issues reported by the build bot and
resend (as a patch separate from the rest of this series). Thanks.

Bartosz