linux-kernel - Re: [PATCH v3 02/22] drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4yeqvg3wnlr2bhb54zutgqpkehrodat5w5x4rr5qjlrc2ts3pz@gr2iosycclpl>
Date: Sat, 10 May 2025 10:43:04 +0200
From: Maxime Ripard <mripard@...nel.org>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Andrzej Hajda <andrzej.hajda@...el.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Jagan Teki <jagan@...rulasolutions.com>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, 
	Douglas Anderson <dianders@...omium.org>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, 
	Krzysztof Kozlowski <krzk@...nel.org>, Anusha Srivatsa <asrivats@...hat.com>, 
	Paul Kocialkowski <paulk@...-base.io>, Dmitry Baryshkov <lumag@...nel.org>, 
	Hui Pu <Hui.Pu@...ealthcare.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	dri-devel@...ts.freedesktop.org, asahi@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	chrome-platform@...ts.linux.dev, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org, linux-amlogic@...ts.infradead.org, 
	linux-renesas-soc@...r.kernel.org, platform-driver-x86@...r.kernel.org, 
	linux-samsung-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org, 
	linux-stm32@...md-mailman.stormreply.com, Manikandan Muralidharan <manikandan.m@...rochip.com>, 
	Adam Ford <aford173@...il.com>, Adrien Grassein <adrien.grassein@...il.com>, 
	Aleksandr Mishin <amishin@...rgos.ru>, Andy Yan <andy.yan@...k-chips.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Benson Leung <bleung@...omium.org>, 
	Biju Das <biju.das.jz@...renesas.com>, Christoph Fritz <chf.fritz@...glemail.com>, 
	Cristian Ciocaltea <cristian.ciocaltea@...labora.com>, Detlev Casanova <detlev.casanova@...labora.com>, 
	Dharma Balasubiramani <dharma.b@...rochip.com>, Guenter Roeck <groeck@...omium.org>, 
	Heiko Stuebner <heiko@...ech.de>, Jani Nikula <jani.nikula@...el.com>, Janne Grunau <j@...nau.net>, 
	Jerome Brunet <jbrunet@...libre.com>, Jesse Van Gavere <jesseevg@...il.com>, 
	Kevin Hilman <khilman@...libre.com>, Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, 
	Liu Ying <victor.liu@....com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, 
	Matthias Brugger <matthias.bgg@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Phong LE <ple@...libre.com>, Sasha Finkelstein <fnkl.kernel@...il.com>, 
	Sugar Zhang <sugar.zhang@...k-chips.com>, Sui Jingfeng <sui.jingfeng@...ux.dev>, 
	Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, Vitalii Mordan <mordan@...ras.ru>
Subject: Re: [PATCH v3 02/22] drm: convert many bridge drivers from
 devm_kzalloc() to devm_drm_bridge_alloc() API

On Fri, May 09, 2025 at 03:53:28PM +0200, Luca Ceresoli wrote:
> devm_drm_bridge_alloc() is the new API to be used for allocating (and
> partially initializing) a private driver struct embedding a struct
> drm_bridge.
> 
> For many drivers having a simple code flow in the probe function, this
> commit does a mass conversion automatically with the following semantic
> patch. The changes have been reviewed manually for correctness as well as
> to find any false positives.
> 
> The patch has been applied with the explicit exclusion of bridge/panel.c,
> handled by a separate patch.
> 
> After applying the semantic patch, manually fixed these issues:
> 
>  - 4 drivers need ERR_CAST() instead of PTR_ERR() as the function calling
>    devm_drm_bridge_alloc() returns a pointer
>  - re-added empty lines and comments that the script had removed but that
>    should stay
> 
>   @@
>   type T;
>   identifier C;
>   identifier BR;
>   expression DEV;
>   expression FUNCS;
>   @@
>   -T *C;
>   +T *C;
>    ...
>   (
>   -C = devm_kzalloc(DEV, ...);
>   -if (!C)
>   -    return -ENOMEM;
>   +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
>   +if (IS_ERR(C))
>   +     return PTR_ERR(C);
>   |
>   -C = devm_kzalloc(DEV, ...);
>   -if (!C)
>   -    return ERR_PTR(-ENOMEM);
>   +C = devm_drm_bridge_alloc(DEV, T, BR, FUNCS);
>   +if (IS_ERR(C))
>   +     return PTR_ERR(C);
>   )
>    ...
>   -C->BR.funcs = FUNCS;
> 
> Reviewed-by: Manikandan Muralidharan <manikandan.m@...rochip.com> # microchip-lvds.c
> Reviewed-by: Douglas Anderson <dianders@...omium.org> # parade-ps8640
> Tested-by: Douglas Anderson <dianders@...omium.org> # parade-ps8640
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

Acked-by: Maxime Ripard <mripard@...nel.org>

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (274 bytes)