lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c91d99c9-0ecb-4dcd-9beb-5a1e9fadc619@kernel.org> Date: Sat, 10 May 2025 16:57:44 +0200 From: Krzysztof Kozlowski <krzk@...nel.org> To: Conor Dooley <conor@...nel.org> Cc: Nick Hu <nick.hu@...ive.com>, Cyan Yang <cyan.yang@...ive.com>, Samuel Holland <samuel.holland@...ive.com>, devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com> Subject: Re: [PATCH] dt-bindings: power: Add SiFive Domain Management controllers On 09/05/2025 17:57, Conor Dooley wrote: >>> + - pattern: "^sifive,[ts]mc1$" >>> + - items: >>> + - {} >>> + - const: sifive,cmc3 >>> + - const: sifive,cmc2 >>> + - items: >>> + - {} >>> + - const: sifive,cmc2 >> >> All of this is just unexpected. Why any compatible should come with >> these? > > It's also not quite correct either, right? Or may not be correct at > least. It permits "xxx", "tmc2", "smc1" and "xxx", "smc2", "tmc1" > which mean that the smc and tmc must be identical in terms of > programming model. Yep > >> You need to use SoC specific compatibles. > > I think there's some slack to provide here, sifive are upstreaming it in > advance of there being customers (or customers ready to upstream) and this > format allows us to accept bindings/drivers and the customer will have > to add a soc-specific compatible in order to actually use these in a > dts. I think it's better to accept something along these lines than Sure, commit msg should explain that and probably these {} wildcards should have comment as well. > stall out until a customer decides to upstream their user. That said, I > would expect this to come (as you mentioned above) with the driver. > Best regards, Krzysztof
Powered by blists - more mailing lists