linux-kernel - Re: [PATCH] scsi: smartpqi: Fix the race condition between pqi_tmf_worker and pqi_sdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a497880a-e6a3-409d-8c4e-d5086459ce3a@sangfor.com.cn>
Date: Sat, 10 May 2025 09:15:13 +0800
From: zhuwei <zhuwei@...gfor.com.cn>
To: Don.Brace@...rochip.com
Cc: dinghui@...gfor.com.cn, zengzhicong@...gfor.com.cn,
 James.Bottomley@...senpartnership.com, martin.petersen@...cle.com,
 storagedev@...rochip.com, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] scsi: smartpqi: Fix the race condition between
 pqi_tmf_worker and pqi_sdev_destroy



On 2025/5/9 23:19, Don.Brace@...rochip.com wrote:
> 
> ---------- Forwarded message ---------
> From: Zhu Wei <zhuwei@...gfor.com.cn>
> Date: Thu, May 8, 2025 at 7:57 AM
> Subject: [PATCH] scsi: smartpqi: Fix the race condition between pqi_tmf_worker and pqi_sdev_destroy
> To: <don.brace@...rochip.com>, <kevin.barnett@...rochip.com>
> Cc: <dinghui@...gfor.com.cn>, <zengzhicong@...gfor.com.cn>, <James.Bottomley@...senpartnership.com>, <martin.petersen@...cle.com>, <storagedev@...rochip.com>, <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>, Zhu Wei <zhuwei@...gfor.com.cn>
> 
> 
> There is a race condition between pqi_sdev_destroy and pqi_tmf_worker.
> After pqi_free_device is released, pqi_tmf_worker will still use device.
> 
> Don: Thank-you for your patch, however we recently applied a similar patch to our internal repo.
> Don: But more checking is done for removed devices.
> Don: When this patch has been tested internally, we will post it up for review.
> Don: I will add a Reported-By tag with your name.

Ok, hope smartpqi gets better.

> Don: So Nak.
> 
> 
> 
> kasan report:
> [ 1933.765810] ==================================================================
> [ 1933.771862] scsi 15:0:20:0: Direct-Access     ATA      WDC  WUH722222AL WTS2 PQ: 0 ANSI: 6
> [ 1933.779190] BUG: KASAN: use-after-free in pqi_device_wait_for_pending_io+0x9e/0x600 [smartpqi]
> ......
> --
> 2.43.0
>