linux-kernel - Re: [RFC 18/19] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC_iWjLwC1t=Xrxb9QUxRpRqHCuXLcC6eRtu+Tr=NbpS-BFt4A@mail.gmail.com>
Date: Sat, 10 May 2025 10:28:37 +0300
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Byungchul Park <byungchul@...com>
Cc: willy@...radead.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-mm@...ck.org, kernel_team@...ynix.com, kuba@...nel.org, 
	almasrymina@...gle.com, harry.yoo@...cle.com, hawk@...nel.org, 
	akpm@...ux-foundation.org, ast@...nel.org, daniel@...earbox.net, 
	davem@...emloft.net, john.fastabend@...il.com, andrew+netdev@...n.ch, 
	edumazet@...gle.com, pabeni@...hat.com, vishal.moola@...il.com
Subject: Re: [RFC 18/19] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem()

On Fri, 9 May 2025 at 14:51, Byungchul Park <byungchul@...com> wrote:
>
> The page pool members in struct page cannot be removed unless it's not
> allowed to access any of them via struct page.
>
> Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but
> just wrap page_pool_get_dma_addr_netmem() safely.
>
> Signed-off-by: Byungchul Park <byungchul@...com>
> ---
>  include/net/page_pool/helpers.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h
> index 4deb0b32e4bac..7e0395c70bfa2 100644
> --- a/include/net/page_pool/helpers.h
> +++ b/include/net/page_pool/helpers.h
> @@ -441,12 +441,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem)
>   */
>  static inline dma_addr_t page_pool_get_dma_addr(const struct page *page)
>  {
> -       dma_addr_t ret = page->dma_addr;
> -
> -       if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA)
> -               ret <<= PAGE_SHIFT;
> -
> -       return ret;
> +       return page_pool_get_dma_addr_netmem(page_to_netmem(page));
>  }
>
>  static inline void __page_pool_dma_sync_for_cpu(const struct page_pool *pool,
> --
> 2.17.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>