linux-kernel - Re: [PATCH v5 07/10] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5a0263f4-1073-45a8-a8aa-76028a2d0b6e@app.fastmail.com>
Date: Sun, 11 May 2025 12:14:46 +0200
From: "Sven Peter" <sven@...npeter.dev>
To: "Stefan Wahren" <wahrenst@....net>
Cc: "Janne Grunau" <j@...nau.net>, "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
 "Neal Gompa" <neal@...pa.dev>, "Hector Martin" <marcan@...can.st>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>, "Sebastian Reichel" <sre@...nel.org>,
 "Lee Jones" <lee@...nel.org>, "Marc Zyngier" <maz@...nel.org>,
 "Russell King" <rmk+kernel@...linux.org.uk>, asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org,
 "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v5 07/10] power: reset: macsmc-reboot: Add driver for rebooting via
 Apple SMC

Hi Stefan,

On Sun, May 11, 2025, at 12:07, Stefan Wahren wrote:
> Hi Sven,
>
> Am 11.05.25 um 10:18 schrieb Sven Peter via B4 Relay:

[...]

>> +/* Helpers to read/write a u8 given a struct nvmem_cell */
>> +static int nvmem_cell_get_u8(struct nvmem_cell *cell)
>> +{
>> +	size_t len;
>> +	u8 val;
>> +	void *ret = nvmem_cell_read(cell, &len);
> in case this series needs a respin, please rename the pointer (e.g. 
> buf). This is very unusual, because ret is usually of type int.

That's indeed odd, I'll rename it.


Thanks,


Sven