linux-kernel - Re: [PATCH] extcon: adc-jack: Cleanup wakeup source only if it was enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH2KXuX4d3Ox7CEV4gcVAjFHPMhPC6AzT5LAc3UN5Dzj=A@mail.gmail.com>
Date: Sun, 11 May 2025 20:54:11 +0900
From: Chanwoo Choi <chanwoo@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi <cw00.choi@...sung.com>, 
	linux-kernel@...r.kernel.org, 
	Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] extcon: adc-jack: Cleanup wakeup source only if it was enabled

Applied it.

Thanks.

On Fri, May 9, 2025 at 4:18 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> Driver in the probe enables wakeup source conditionally, so the cleanup
> path should do the same - do not release the wakeup source memory if it
> was not allocated.
>
> Reported-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Closes: https://lore.kernel.org/r/22aaebb7-553b-4571-8a43-58a523241082@wanadoo.fr/
> Fixes: 63c223dcdd49 ("extcon: adc-jack: Fix wakeup source leaks on device unbind")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/extcon/extcon-adc-jack.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c
> index 557930394abd..7e3c9f38297b 100644
> --- a/drivers/extcon/extcon-adc-jack.c
> +++ b/drivers/extcon/extcon-adc-jack.c
> @@ -164,7 +164,8 @@ static void adc_jack_remove(struct platform_device *pdev)
>  {
>         struct adc_jack_data *data = platform_get_drvdata(pdev);
>
> -       device_init_wakeup(&pdev->dev, false);
> +       if (data->wakeup_source)
> +               device_init_wakeup(&pdev->dev, false);
>         free_irq(data->irq, data);
>         cancel_work_sync(&data->handler.work);
>  }
> --
> 2.45.2
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics