| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250511094546-mutt-send-email-mst@kernel.org>
Date: Sun, 11 May 2025 09:45:55 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Igor Mammedov <imammedo@...hat.com>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Shiju Jose <shiju.jose@...wei.com>, qemu-arm@...gnu.org,
qemu-devel@...gnu.org,
Philippe Mathieu-Daudé <philmd@...aro.org>,
Gavin Shan <gshan@...hat.com>, Ani Sinha <anisinha@...hat.com>,
Cleber Rosa <crosa@...hat.com>,
Dongjiu Geng <gengdongjiu1@...il.com>,
Eduardo Habkost <eduardo@...kost.net>,
Eric Blake <eblake@...hat.com>, John Snow <jsnow@...hat.com>,
Marcel Apfelbaum <marcel.apfelbaum@...il.com>,
Markus Armbruster <armbru@...hat.com>,
Michael Roth <michael.roth@....com>,
Paolo Bonzini <pbonzini@...hat.com>,
Peter Maydell <peter.maydell@...aro.org>,
Shannon Zhao <shannon.zhaosl@...il.com>,
Yanan Wang <wangyanan55@...wei.com>, Zhao Liu <zhao1.liu@...el.com>,
kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 00/20] Change ghes to use HEST-based offsets and add
support for error inject
On Sun, May 11, 2025 at 09:45:04AM -0400, Michael S. Tsirkin wrote:
> On Fri, Mar 07, 2025 at 08:14:29PM +0100, Mauro Carvalho Chehab wrote:
> > Hi Michael,
> >
> > I'm sending v8 to avoid a merge conflict with v7 due to this
> > changeset:
> >
> > 611f3bdb20f7 ("hw/acpi/ghes: Make static")
>
>
>
> Applied 1-13.
> Patch 14 needs to apply compat to 10.0 machine type as well.
Sorry i meant 1-11.
>
> > As ghes_record_cper_errors() was written since the beginning
> > to be public and used by ghes-cper.c. It ended being meged
> > earlier because the error-injection series become too big,
> > so it was decided last year to split in two to make easier for
> > reviewers and maintainers to discuss.
> >
> > Anyway, as mentioned on v7, I guess we're ready to merge this
> > series, as patches here have been thoughfully reviewed mainly
> > by Igor and Jonathan over the last 5-6 months.
> >
> > The only change from v7 is a minor editorial change at HEST doc
> > spec, and the addition of Igor and Jonathan's A-B/R-B.
> >
> > This series change the way HEST table offsets are calculated,
> > making them identical to what an OSPM would do and allowing
> > multiple HEST entries without causing migration issues. It open
> > space to add HEST support for non-arm architectures, as now
> > the number and type of HEST notification entries are not
> > hardcoded at ghes.c. Instead, they're passed as a parameter
> > from the arch-dependent init code.
> >
> > With such issue addressed, it adds a new notification type and
> > add support to inject errors via a Python script. The script
> > itself is at the final patch.
> >
> > ---
> > v8:
> > - added a patch to revert recently-added changeset causing a
> > conflict with these. All remaining patches are identical.
> >
> > v7:
> > - minor editorial change at the patch updating HEST doc spec
> > with the new workflow
> >
> > v6:
> > - some minor nits addressed:
> > - use GPA instead of offset;
> > - merged two patches;
> > - fixed a couple of long line coding style issues;
> > - the HEST/DSDT diff inside a patch was changed to avoid troubles
> > applying it.
> >
> > v5:
> > - make checkpatch happier;
> > - HEST table is now tested;
> > - some changes at HEST spec documentation to align with code changes;
> > - extra care was taken with regards to git bisectability.
> >
> > v4:
> > - added an extra comment for AcpiGhesState structure;
> > - patches reordered;
> > - no functional changes, just code shift between the patches in this series.
> >
> > v3:
> > - addressed more nits;
> > - hest_add_le now points to the beginning of HEST table;
> > - removed HEST from tests/data/acpi;
> > - added an extra patch to not use fw_cfg with virt-10.0 for hw_error_le
> >
> > v2:
> > - address some nits;
> > - improved ags cleanup patch and removed ags.present field;
> > - added some missing le*_to_cpu() calls;
> > - update date at copyright for new files to 2024-2025;
> > - qmp command changed to: inject-ghes-v2-error ans since updated to 10.0;
> > - added HEST and DSDT tables after the changes to make check target happy.
> > (two patches: first one whitelisting such tables; second one removing from
> > whitelist and updating/adding such tables to tests/data/acpi)
> >
> > Mauro Carvalho Chehab (20):
> > tests/acpi: virt: add an empty HEST file
> > tests/qtest/bios-tables-test: extend to also check HEST table
> > tests/acpi: virt: update HEST file with its current data
> > Revert "hw/acpi/ghes: Make ghes_record_cper_errors() static"
> > acpi/ghes: Cleanup the code which gets ghes ged state
> > acpi/ghes: prepare to change the way HEST offsets are calculated
> > acpi/ghes: add a firmware file with HEST address
> > acpi/ghes: Use HEST table offsets when preparing GHES records
> > acpi/ghes: don't hard-code the number of sources for HEST table
> > acpi/ghes: add a notifier to notify when error data is ready
> > acpi/generic_event_device: Update GHES migration to cover hest addr
> > acpi/generic_event_device: add logic to detect if HEST addr is
> > available
> > acpi/generic_event_device: add an APEI error device
> > tests/acpi: virt: allow acpi table changes at DSDT and HEST tables
> > arm/virt: Wire up a GED error device for ACPI / GHES
> > qapi/acpi-hest: add an interface to do generic CPER error injection
> > acpi/generic_event_device.c: enable use_hest_addr for QEMU 10.x
> > tests/acpi: virt: update HEST and DSDT tables
> > docs: hest: add new "etc/acpi_table_hest_addr" and update workflow
> > scripts/ghes_inject: add a script to generate GHES error inject
> >
> > MAINTAINERS | 10 +
> > docs/specs/acpi_hest_ghes.rst | 28 +-
> > hw/acpi/Kconfig | 5 +
> > hw/acpi/aml-build.c | 10 +
> > hw/acpi/generic_event_device.c | 44 ++
> > hw/acpi/ghes-stub.c | 7 +-
> > hw/acpi/ghes.c | 233 ++++--
> > hw/acpi/ghes_cper.c | 38 +
> > hw/acpi/ghes_cper_stub.c | 19 +
> > hw/acpi/meson.build | 2 +
> > hw/arm/virt-acpi-build.c | 35 +-
> > hw/arm/virt.c | 19 +-
> > hw/core/machine.c | 2 +
> > include/hw/acpi/acpi_dev_interface.h | 1 +
> > include/hw/acpi/aml-build.h | 2 +
> > include/hw/acpi/generic_event_device.h | 1 +
> > include/hw/acpi/ghes.h | 51 +-
> > include/hw/arm/virt.h | 2 +
> > qapi/acpi-hest.json | 35 +
> > qapi/meson.build | 1 +
> > qapi/qapi-schema.json | 1 +
> > scripts/arm_processor_error.py | 476 ++++++++++++
> > scripts/ghes_inject.py | 51 ++
> > scripts/qmp_helper.py | 703 ++++++++++++++++++
> > target/arm/kvm.c | 7 +-
> > tests/data/acpi/aarch64/virt/DSDT | Bin 5196 -> 5240 bytes
> > .../data/acpi/aarch64/virt/DSDT.acpihmatvirt | Bin 5282 -> 5326 bytes
> > tests/data/acpi/aarch64/virt/DSDT.memhp | Bin 6557 -> 6601 bytes
> > tests/data/acpi/aarch64/virt/DSDT.pxb | Bin 7679 -> 7723 bytes
> > tests/data/acpi/aarch64/virt/DSDT.topology | Bin 5398 -> 5442 bytes
> > tests/data/acpi/aarch64/virt/HEST | Bin 0 -> 224 bytes
> > tests/qtest/bios-tables-test.c | 2 +-
> > 32 files changed, 1695 insertions(+), 90 deletions(-)
> > create mode 100644 hw/acpi/ghes_cper.c
> > create mode 100644 hw/acpi/ghes_cper_stub.c
> > create mode 100644 qapi/acpi-hest.json
> > create mode 100644 scripts/arm_processor_error.py
> > create mode 100755 scripts/ghes_inject.py
> > create mode 100755 scripts/qmp_helper.py
> > create mode 100644 tests/data/acpi/aarch64/virt/HEST
> >
> > --
> > 2.48.1
> >
Powered by blists - more mailing lists