linux-kernel - Re: question on sound/isa/msnd/msnd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r00vxmjs.wl-tiwai@suse.de>
Date: Sun, 11 May 2025 16:13:43 +0200
From: Takashi Iwai <tiwai@...e.de>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	krzysztof.h1@...pl,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: question on sound/isa/msnd/msnd_midi.c

On Thu, 08 May 2025 13:36:04 +0200,
Dr. David Alan Gilbert wrote:
> 
> Hi,
>    I noticed that nothing calls snd_msndmidi_new in
> sound/isa/msnd/msnd_midi.c and was about to delete it, but I'm not
> too sure - I think it's actually a bug where it should be called.
> 
>   This code was added in 2009 by
> commit f6c638350275 ("ALSA: Turtle Beach Multisound Classic/Pinnacle driver")
> (Pretty new for an ISA card!)
> 
> Looking at msnd_midi.c the only function in there that anything
> calls is snd_msndmidi_input_read() called by msnd_pinnacle.c but that
> is guarded by a check:
> 
>   146    if (chip->msndmidi_mpu)
>   147          snd_msndmidi_input_read(chip->msndmidi_mpu);   
> 
> but I don't think anything sets that msndmidi_mpu, since the only
> thing that could is snd_msndmidi_new() which isn't called.
> 
> I see that the original poster didn't test the external midi:
>    https://mailman.alsa-project.org/hyperkitty/list/alsa-devel@alsa-project.org/message/CWPYLPLJQEK64UU3YFCAMVXGDY42QKF2/
> so I guess this has always been missing.
> 
> I don't have the hardware to test.
> 
> Thoughts?

Well, it's a very old code on an old interface, and if it's not used
(even because of a typo or an overlook), then it's basically no chance
to be used in future.  Let's rip off.


thanks,

Takashi