linux-kernel - Re: [PATCH] proc: Show the mountid associated with exe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC1kPDP4MCfUFkrQu0-Fg3Du7bz25QAY1Wyqdi_HGVbw326U1w@mail.gmail.com>
Date: Mon, 12 May 2025 00:19:01 +0800
From: Chen Linxuan <chenlinxuan@...ontech.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: WangYuli <wangyuli@...ontech.com>, brauner@...nel.org, jack@...e.cz, 
	akpm@...ux-foundation.org, tglx@...utronix.de, jlayton@...nel.org, 
	frederic@...nel.org, chenlinxuan@...ontech.com, xu.xin16@....com.cn, 
	adrian.ratiu@...labora.com, lorenzo.stoakes@...cle.com, mingo@...nel.org, 
	felix.moessbauer@...mens.com, linux-kernel@...r.kernel.org, 
	linux-fsdevel@...r.kernel.org, zhanjun@...ontech.com, niecheng1@...ontech.com, 
	guanwentao@...ontech.com
Subject: Re: [PATCH] proc: Show the mountid associated with exe

On Sun, May 11, 2025 at 10:22 PM Al Viro <viro@...iv.linux.org.uk> wrote:

> Excuse me, just what is that path_get/path_put for?  If you have
> an opened file, you do have its ->f_path pinned and unchanging.
> Otherwise this call of path_get() would've itself been unsafe...

I am not very familiar with how these functions should be used.
I just copied similar logic from proc_exe_link and added a path_put.
Maybe I made a stupid mistake...