linux-kernel - Re: question on sound/isa/msnd/msnd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aCDfCpeaD2eDLwFI@gallifrey>
Date: Sun, 11 May 2025 17:31:54 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Takashi Iwai <tiwai@...e.de>
Cc: perex@...ex.cz, tiwai@...e.com, krzysztof.h1@...pl,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: question on sound/isa/msnd/msnd_midi.c

* Dr. David Alan Gilbert (linux@...blig.org) wrote:
> * Takashi Iwai (tiwai@...e.de) wrote:
> > On Thu, 08 May 2025 13:36:04 +0200,
> > Dr. David Alan Gilbert wrote:
> > > 
> > > Hi,
> > >    I noticed that nothing calls snd_msndmidi_new in
> > > sound/isa/msnd/msnd_midi.c and was about to delete it, but I'm not
> > > too sure - I think it's actually a bug where it should be called.
> > > 
> > >   This code was added in 2009 by
> > > commit f6c638350275 ("ALSA: Turtle Beach Multisound Classic/Pinnacle driver")
> > > (Pretty new for an ISA card!)
> > > 
> > > Looking at msnd_midi.c the only function in there that anything
> > > calls is snd_msndmidi_input_read() called by msnd_pinnacle.c but that
> > > is guarded by a check:
> > > 
> > >   146    if (chip->msndmidi_mpu)
> > >   147          snd_msndmidi_input_read(chip->msndmidi_mpu);   
> > > 
> > > but I don't think anything sets that msndmidi_mpu, since the only
> > > thing that could is snd_msndmidi_new() which isn't called.
> > > 
> > > I see that the original poster didn't test the external midi:
> > >    https://mailman.alsa-project.org/hyperkitty/list/alsa-devel@alsa-project.org/message/CWPYLPLJQEK64UU3YFCAMVXGDY42QKF2/
> > > so I guess this has always been missing.
> > > 
> > > I don't have the hardware to test.
> > > 
> > > Thoughts?
> > 
> > Well, it's a very old code on an old interface, and if it's not used
> > (even because of a typo or an overlook), then it's basically no chance
> > to be used in future.  Let's rip off.
> 
> Ok, I'll cut a patch to remove snd_msndmidi_new() and then probably the whole
> of msnd_midi.c and the call in msnd_pinnacle.c

Patch sent, see message: 20250511172957.1001583-1-linux@...blig.org

Thanks,

Dave

> Dave
> 
> > 
> > thanks,
> > 
> > Takashi
> > 
> -- 
>  -----Open up your eyes, open up your mind, open up your code -------   
> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> \        dave @ treblig.org |                               | In Hex /
>  \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/