linux-kernel - Re: [PATCH v2 1/2] soc: qcom: socinfo: add SM8750 SoC ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yv3ageskkr2mwtgnrldlpgmvgqbxfullp52w7yjg47lm34h5cb@n27gdmljehyc>
Date: Sun, 11 May 2025 17:30:52 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/2] soc: qcom: socinfo: add SM8750 SoC ID

On Thu, May 08, 2025 at 07:16:34PM +0530, Mukesh Ojha wrote:
> Update soc_id table for the Qualcomm SM8750 SoC to represent
> SM8750 machine.
> 
> Signed-off-by: Mukesh Ojha <mukesh.ojha@....qualcomm.com>
> ---
> Changes in v2:
>  - corrected the order. 

I believe the feedback given related to two different issues with
"order", and you fixed the sort order of soc_id[] but not the other one.

Patch 1 can not be compiled without patch 2, so applying this series
would break "git bisect" of the master branch.


I'm applying the two patches in opposite order, but please do make sure
that the kernel is buildable and functional after each patch in the
future.

Regards,
Bjorn

> 
>  drivers/soc/qcom/socinfo.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 18d7f1be9093..8c4147737c35 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -444,6 +444,7 @@ static const struct soc_id soc_id[] = {
>  	{ qcom_board_id(IPQ5302) },
>  	{ qcom_board_id(QCS8550) },
>  	{ qcom_board_id(QCM8550) },
> +	{ qcom_board_id(SM8750)  },
>  	{ qcom_board_id(IPQ5300) },
>  	{ qcom_board_id(IPQ5321) },
>  	{ qcom_board_id(IPQ5424) },
> -- 
> 2.34.1
>