linux-kernel - Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCA4KP1nNFVzphPR@kernel.org>
Date: Sun, 11 May 2025 08:39:52 +0300
From: Mike Rapoport <rppt@...nel.org>
To: Donet Tom <donettom@...ux.ibm.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Oscar Salvador <osalvador@...e.de>, Zi Yan <ziy@...dia.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, rafael@...nel.org,
	Danilo Krummrich <dakr@...nel.org>,
	Ritesh Harjani <ritesh.list@...il.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Yury Norov <yury.norov@...il.com>,
	Dave Jiang <dave.jiang@...el.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration
 to reduce boot time

Hi Donet,

On Fri, May 09, 2025 at 09:10:34PM +0530, Donet Tom wrote:
> > > 
> > > Then we can drop the call to register_memory_blocks_under_node() from
> > > register_one_node() and add creation of memory blocks to
> > > node_dev_init(),
> > > i.e.
> > > 
> > > node_dev_init()
> > >    for_each_node(nid)
> > >      __register_one_node(nid)
> > >        for_each_mem_region()
> > >          /* create memory block if node matches */
> > 
> > Yes exactly, that makes sense.
> 
> Hi Andrew and Mike
> 
> Based on the discussion so far, it is clear that the patch will work in all cases,
> including when CONFIG_ARCH_KEEP_MEMBLOCK  is disabled. Just checking —
> would you prefer to take this version, or should I send a v4?

During the discussion we concluded that the right thing to do seems to drop
the call to register_memory_blocks_under_node() from register_one_node()
and make node_dev_init() call __register_one_node() and then create memory
blocks for each memblock region.

Can you please make v4 along those lines?
 
> Thanks
> Donet

-- 
Sincerely yours,
Mike.