linux-kernel - Re: [PATCH] Makefile: remove dependency on archscripts for header installation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8bd773107cf5a78359bcf03a0dcd2785@lxm.se>
Date: Mon, 12 May 2025 17:55:53 +0200
From: Henrik Lindström <henrik@....se>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: nathan@...nel.org, nicolas.schier@...ux.dev,
 linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Makefile: remove dependency on archscripts for header
 installation

That was my attempt to explain why i wanted to make this change, but 
you're right that it's really just a small cleanup.

Will go again with a simpler message, thanks.

On 2025-05-12 14:23, Masahiro Yamada wrote:
> On Sun, May 11, 2025 at 12:34 AM Henrik Lindström <henrik@....se> 
> wrote:
>> 
>> There doesn't seem to be any purpose behind this dependency, and it 
>> prevents
>> installing x86 and mips headers on non Linux systems. Doing so is 
>> useful when
>> building a cross compiler targetting Linux, which requires the header 
>> files.
>> 
>> Signed-off-by: Henrik Lindström <henrik@....se>
>> ---
> 
> This clean-up makes sense.
> 
> However, I could not understand the commit description
> about the non-Linux systems.
> 
> In my understanding, archscripts is not required here
> regardless of whether it is a Linux or non-Linux system.
> 
> So, the following description sound good to me:
> 
>   archscripts has nothing to do with headers_install.
> 
> 
> Could you send v2 with the simplified commit log?
> 
> 
> 
> 
> 
> 
>>  Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Makefile b/Makefile
>> index b29cc321ffd9..0234faafe8f0 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1366,7 +1366,7 @@ PHONY += archheaders archscripts
>>  hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
>> 
>>  PHONY += headers
>> -headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders 
>> archscripts
>> +headers: $(version_h) scripts_unifdef uapi-asm-generic archheaders
>>  ifdef HEADER_ARCH
>>         $(Q)$(MAKE) -f $(srctree)/Makefile HEADER_ARCH= 
>> SRCARCH=$(HEADER_ARCH) headers
>>  else
>> --
>> 2.39.5
>> 
> 
> 
> --
> Best Regards
> Masahiro Yamada