linux-kernel - Re: [PATCH net-next v4 5/5] eth: fbnic: Add devlink dev flash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fc956cf-8bc8-4822-90d3-9d8200e483b0@intel.com>
Date: Mon, 12 May 2025 11:48:52 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Lee Trager <lee@...ger.us>, Alexander Duyck <alexanderduyck@...com>,
	"Jakub Kicinski" <kuba@...nel.org>, <kernel-team@...a.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Jonathan Corbet
	<corbet@....net>, Andrew Lunn <andrew+netdev@...n.ch>, Mohsin Bashir
	<mohsin.bashr@...il.com>, Sanman Pradhan <sanman.p211993@...il.com>, Su Hui
	<suhui@...china.com>, Al Viro <viro@...iv.linux.org.uk>, Michal Swiatkowski
	<michal.swiatkowski@...ux.intel.com>
CC: Andrew Lunn <andrew@...n.ch>, <netdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v4 5/5] eth: fbnic: Add devlink dev flash support



On 5/9/2025 5:21 PM, Lee Trager wrote:
> Add support to update the CMRT and control firmware as well as the UEFI
> driver on fbnic using devlink dev flash.
> 
> Make sure the shutdown / quiescence paths like suspend take the devlink
> lock to prevent them from interrupting the FW flashing process.
> 
> Signed-off-by: Lee Trager <lee@...ger.us>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
Glad to see the work I put into the lib/pldmfw is able to be re-used!

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>