linux-kernel - Re: [PATCH RFC 5/5] platform/x86: samsung-galaxybook: Transition to new firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D9UFQL7OM386.2PQP7IG73O0MQ@gmail.com>
Date: Mon, 12 May 2025 16:39:34 -0300
From: "Kurt Borja" <kuurtb@...il.com>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: "Hans de Goede" <hdegoede@...hat.com>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, "Joshua Grisham" <josh@...huagrisham.com>,
 "Mark Pearson" <mpearson-lenovo@...ebb.ca>, "Armin Wolf" <W_Armin@....de>,
 "Mario Limonciello" <mario.limonciello@....com>, "Antheas Kapenekakis"
 <lkml@...heas.dev>, "Derek J. Clark" <derekjohn.clark@...il.com>, "Prasanth
 Ksr" <prasanth.ksr@...l.com>, "Jorge Lopez" <jorge.lopez2@...com>,
 <platform-driver-x86@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <Dell.Client.Kernel@...l.com>
Subject: Re: [PATCH RFC 5/5] platform/x86: samsung-galaxybook: Transition to
 new firmware_attributes API

Hi Thomas,

On Mon May 12, 2025 at 4:12 AM -03, Thomas Weißschuh wrote:
> On 2025-05-09 04:48:37-0300, Kurt Borja wrote:
>> Transition to new firmware_attributes API and replace `enumeration` types
>> with the simpler `boolean` type.
>
> This is an ABI change, using a newly introduced ABI.
> Some elaboration why it does not break userspace would be good.

I thought it was not a big deal since the driver was still new. But TIL
fwupd actually interfaces with the firmware-attributes class.

I won't break the ABI of this driver in the next revision.

-- 
 ~ Kurt

>
>> 
>> Signed-off-by: Kurt Borja <kuurtb@...il.com>
>> ---
>>  drivers/platform/x86/samsung-galaxybook.c | 299 ++++++++++++------------------
>>  1 file changed, 114 insertions(+), 185 deletions(-)
>
> <snip>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)