linux-kernel - Re: [PATCH 02/11] rust: io: Replace Io with MMIo using IoAccess trait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512200734.GA1120867@bhelgaas>
Date: Mon, 12 May 2025 15:07:34 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Andrew Ballance <andrewjballance@...il.com>
Cc: dakr@...nel.org, airlied@...il.com, simona@...ll.ch,
	akpm@...ux-foundation.org, ojeda@...nel.org, alex.gaynor@...il.com,
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com,
	benno.lossin@...ton.me, a.hindborg@...nel.org, aliceryhl@...gle.com,
	tmgross@...ch.edu, gregkh@...uxfoundation.org, rafael@...nel.org,
	bhelgaas@...gle.com, kwilczynski@...nel.org, raag.jadav@...el.com,
	andriy.shevchenko@...ux.intel.com, arnd@...db.de, me@...enk.dev,
	fujita.tomonori@...il.com, daniel.almeida@...labora.com,
	nouveau@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 02/11] rust: io: Replace Io with MMIo using IoAccess trait

On Thu, May 08, 2025 at 10:15:15PM -0500, Andrew Ballance wrote:
> From: Fiona Behrens <me@...enk.dev>
> 
> Replace the Io struct with a new MMIo struct that uses the different
> traits (`IoAccess`, `IoAccess64`, `IoAccessRelaxed` and
> `IoAccess64Relaxed).
> This allows to later implement PortIo and a generic Io framework.

Add blank line between paragraphs.

> +    /// Read data from a give offset known at compile time.

s/give/given/

> +    /// Bound checks are perfomed on compile time, hence if the offset is not known at compile
> +    /// time, the build will fail.

s/perfomed on/performed at/

> +    /// Bound checks are performed on runtime, it fails if the offset (plus type size) is
> +    /// out of bounds.

s/on runtime/at runtime/

> +/// This Takes either `@...d` or `@...te` to generate a single read or write accessor function.

s/This Takes/This takes/