linux-kernel - Re: [PATCH 0/3] tracing: Some cleanups of event trigger code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd64a829c2c76279ccce2640d55b97ecdb6368a3.camel@kernel.org>
Date: Mon, 12 May 2025 15:47:53 -0500
From: Tom Zanussi <zanussi@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mark Rutland
 <mark.rutland@....com>,  Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 0/3] tracing: Some cleanups of event trigger code

Hi Steve,

On Wed, 2025-05-07 at 10:53 -0400, Steven Rostedt wrote:
> These are minor clean ups of the trace_events_trigger code.
> 
> - Rename event_trigger_alloc() to trigger_data_alloc() as it
>   is supposed to be freed by trigger_data_free().
> 
> - Remove unneeded goto outs
> 
> - Add consistent cleanup in event_trigger_parse()
> 
> 
> Miaoqian Lin (1):
>       tracing: Fix error handling in event_trigger_parse()
> 
> Steven Rostedt (2):
>       tracing: Rename event_trigger_alloc() to trigger_data_alloc()
>       tracing: Remove unnecessary "goto out" that simply returns ret
> is trigger code
> 

These all look right to me, and were probably the original intent.

For all 3,

Reviewed-by: Tom Zanussi <zanussi@...nel.org>

Thanks,

Tom

> ----
>  kernel/trace/trace.h                |  8 ++---
>  kernel/trace/trace_events_hist.c    |  2 +-
>  kernel/trace/trace_events_trigger.c | 64 ++++++++++++++++-----------
> ----------
>  3 files changed, 31 insertions(+), 43 deletions(-)