linux-kernel - Re: [PATCH 3/7] pinctrl: armada-37xx: set GPIO output value before setting direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95da9408-dab6-4b69-86f2-6681db9be841@lunn.ch>
Date: Mon, 12 May 2025 23:30:41 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Gabor Juhos <j4g8y7@...il.com>
Cc: Gregory Clement <gregory.clement@...tlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Imre Kaloz <kaloz@...nwrt.org>
Subject: Re: [PATCH 3/7] pinctrl: armada-37xx: set GPIO output value before
 setting direction

On Mon, May 12, 2025 at 04:22:39PM +0200, Gabor Juhos wrote:
> Changing the direction before updating the output value in the
> OUTPUT_VAL register may result in a glitch on the output line
> if the previous value in the OUTPUT_VAL register is different
> from the one we want to set.
> 
> In order to avoid that, update the output value before changing
> the direction.
> 
> Cc: stable@...r.kernel.org
> Fixes: 6702abb3bf23 ("pinctrl: armada-37xx: Fix direction_output() callback behavior")
> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
> Signed-off-by: Imre Kaloz <kaloz@...nwrt.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew