linux-kernel - Re: [PATCH v3 02/17] cxl: docs - access-coordinates doc fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3be8c20d-d08c-4f77-b1e9-2647e7da50b4@intel.com>
Date: Mon, 12 May 2025 15:47:39 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Gregory Price <gourry@...rry.net>, linux-cxl@...r.kernel.org
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-team@...a.com, dave@...olabs.net, jonathan.cameron@...wei.com,
 alison.schofield@...el.com, vishal.l.verma@...el.com, ira.weiny@...el.com,
 dan.j.williams@...el.com, corbet@....net,
 Randy Dunlap <rdunlap@...radead.org>, Bagas Sanjaya <bagasdotme@...il.com>
Subject: Re: [PATCH v3 02/17] cxl: docs - access-coordinates doc fixups



On 5/12/25 9:21 AM, Gregory Price wrote:
> Place the hierarchy diagram in access-coordinates.rst in a code block.
> 
> Fix a few grammar issues.
> 
> Suggested-by: Randy Dunlap <rdunlap@...radead.org>
> Suggested-by: Bagas Sanjaya <bagasdotme@...il.com>
> Signed-off-by: Gregory Price <gourry@...rry.net>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
>  .../cxl/linux/access-coordinates.rst          | 30 +++++++++----------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/driver-api/cxl/linux/access-coordinates.rst b/Documentation/driver-api/cxl/linux/access-coordinates.rst
> index b07950ea30c9..e408ecbc4038 100644
> --- a/Documentation/driver-api/cxl/linux/access-coordinates.rst
> +++ b/Documentation/driver-api/cxl/linux/access-coordinates.rst
> @@ -26,20 +26,20 @@ There can be multiple switches under an RP. There can be multiple RPs under
>  a CXL Host Bridge (HB). There can be multiple HBs under a CXL Fixed Memory
>  Window Structure (CFMWS).
>  
> -An example hierarchy:
> +An example hierarchy::
>  
> ->                CFMWS 0
> ->                  |
> ->         _________|_________
> ->        |                   |
> ->    ACPI0017-0          ACPI0017-1
> -> GP0/HB0/ACPI0016-0   GP1/HB1/ACPI0016-1
> ->    |          |        |           |
> ->   RP0        RP1      RP2         RP3
> ->    |          |        |           |
> ->  SW 0       SW 1     SW 2        SW 3
> ->  |   |      |   |    |   |       |   |
> -> EP0 EP1    EP2 EP3  EP4  EP5    EP6 EP7
> +                CFMWS 0
> +                  |
> +         _________|_________
> +        |                   |
> +    ACPI0017-0          ACPI0017-1
> + GP0/HB0/ACPI0016-0   GP1/HB1/ACPI0016-1
> +    |          |        |           |
> +   RP0        RP1      RP2         RP3
> +    |          |        |           |
> +  SW 0       SW 1     SW 2        SW 3
> +  |   |      |   |    |   |       |   |
> + EP0 EP1    EP2 EP3  EP4  EP5    EP6 EP7
>  
>  Computation for the example hierarchy:
>  
> @@ -82,8 +82,8 @@ this point all the bandwidths are aggregated per each host bridge, which is
>  also the index for the resulting xarray.
>  
>  The next step is to take the min() of the per host bridge bandwidth and the
> -bandwidth from the Generic Port (GP). The bandwidths for the GP is retrieved
> -via ACPI tables SRAT/HMAT. The min bandwidth are aggregated under the same
> +bandwidth from the Generic Port (GP). The bandwidths for the GP are retrieved
> +via ACPI tables SRAT/HMAT. The minimum bandwidth are aggregated under the same
>  ACPI0017 device to form a new xarray.
>  
>  Finally, the cxl_region_update_bandwidth() is called and the aggregated