linux-kernel - Re: [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c79d60b3-3029-41ed-bde3-55acd2341da1@infradead.org>
Date: Mon, 12 May 2025 16:18:23 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Werner Sembach <wse@...edocomputers.com>, sfr@...b.auug.org.au,
 linux-next@...r.kernel.org, W_Armin@....de,
 Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86/tuxedo: Prevent invalid Kconfig state



On 5/12/25 5:54 AM, Werner Sembach wrote:
> It was possible to create a uncompileable config, because of missing
> "Depends on" statements in the new Kconfig of the TUXEDO platform driver.
> 
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Closes: https://lore.kernel.org/all/a1d9134f-0567-4a53-a1e7-a55cd6b189a9@infradead.org/

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.


> ---
>  drivers/platform/x86/tuxedo/nb04/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/tuxedo/nb04/Kconfig b/drivers/platform/x86/tuxedo/nb04/Kconfig
> index 411c46c9a1cf0..9e7a9f9230d1c 100644
> --- a/drivers/platform/x86/tuxedo/nb04/Kconfig
> +++ b/drivers/platform/x86/tuxedo/nb04/Kconfig
> @@ -7,6 +7,8 @@
>  
>  config TUXEDO_NB04_WMI_AB
>  	tristate "TUXEDO NB04 WMI AB Platform Driver"
> +	depends on ACPI_WMI
> +	depends on HID
>  	help
>  	  This driver implements the WMI AB device found on TUXEDO notebooks
>  	  with board vendor NB04. This enables keyboard backlight control via a

-- 
~Randy