linux-kernel - Re: [PATCH v3 14/19] dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174709235870.686179.16618194990565341079.robh@kernel.org>
Date: Mon, 12 May 2025 18:25:58 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Cosmin Tanislav <demonsingur@...il.com>
Cc: Tommaso Merciai <tomm.merciai@...il.com>, Liu Ying <victor.liu@....com>, 
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>, 
 Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 Dan Carpenter <dan.carpenter@...aro.org>, 
 Sakari Ailus <sakari.ailus@...ux.intel.com>, devicetree@...r.kernel.org, 
 Dongcheng Yan <dongcheng.yan@...el.com>, 
 Catalin Marinas <catalin.marinas@....com>, 
 Ross Burton <ross.burton@....com>, Will Deacon <will@...nel.org>, 
 Eric Biggers <ebiggers@...gle.com>, 
 Julien Massot <julien.massot@...labora.com>, linux-media@...r.kernel.org, 
 Nícolas F . R . A . Prado <nfraprado@...labora.com>, 
 Taniya Das <quic_tdas@...cinc.com>, Mark Brown <broonie@...nel.org>, 
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
 linux-staging@...ts.linux.dev, Geert Uytterhoeven <geert+renesas@...der.be>, 
 Ricardo Ribalda <ribalda@...omium.org>, 
 linux-arm-kernel@...ts.infradead.org, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Vignesh Raghavendra <vigneshr@...com>, Zhi Mao <zhi.mao@...iatek.com>, 
 Cosmin Tanislav <cosmin.tanislav@...log.com>, 
 Bartosz Golaszewski <brgl@...ev.pl>, Hans Verkuil <hverkuil@...all.nl>, 
 linux-kernel@...r.kernel.org, 
 Niklas Söderlund <niklas.soderlund@...natech.se>, 
 Elinor Montmasson <elinor.montmasson@...oirfairelinux.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Kieran Bingham <kieran.bingham@...asonboard.com>, 
 Mauro Carvalho Chehab <mchehab@...nel.org>, 
 Liam Girdwood <lgirdwood@...il.com>, 
 Laurentiu Palcu <laurentiu.palcu@....nxp.com>, 
 Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v3 14/19] dt-bindings: media: i2c: add MAX9296A,
 MAX96716A, MAX96792A

On Tue, 13 May 2025 00:28:23 +0300, Cosmin Tanislav wrote:
> The MAX9296A deserializer converts single or dual serial inputs to MIPI
> CSI-2 outputs. The GMSL2 links operate at a fixed rate of 3Gbps or 6Gbps
> in the forward direction and 187.5Mbps in the reverse direction.
> In GMSL1 mode, each serial link can be paired with 3.12Gbps or 1.5Gbps
> GMSL1 serializers or operate up to 4.5Gbps with GMSL2 serializers with
> GMSL1 backward compatibility. The MAX9296A supports mixed GMSL2 and
> GMSL1 links. The serial inputs operate independently, allowing videos
> with different timings and resolutions to be received on each input.
> 
> MAX96716A supports both tunnel and pixel mode.
> MAX96792A supports both tunnel and pixel mode, and has two GMSL3 links.
> 
> Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
> ---
>  .../bindings/media/i2c/maxim,max9296a.yaml    | 242 ++++++++++++++++++
>  MAINTAINERS                                   |   6 +
>  2 files changed, 248 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.example.dtb: serializer@40 (maxim,max96717): compatible: 'oneOf' conditional failed, one must be fixed:
	['maxim,max96717'] is too short
	'maxim,max96717' is not one of ['maxim,max9295a', 'maxim,max96717f']
	from schema $id: http://devicetree.org/schemas/media/i2c/maxim,max96717.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.example.dtb: serializer@40 (maxim,max96717): compatible: 'oneOf' conditional failed, one must be fixed:
	['maxim,max96717'] is too short
	'maxim,max96717' is not one of ['maxim,max9295a', 'maxim,max96717f']
	from schema $id: http://devicetree.org/schemas/media/i2c/maxim,max96717.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250512212832.3674722-15-demonsingur@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.