linux-kernel - Re: [PATCH v3 2/4] PCI: hv: Allow dynamic MSI-X vector allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <plrpscito5e76t4dvtukgqm724stsfxim3zv3xqwnjewenee53@72dipu3yunlr>
Date: Mon, 12 May 2025 12:30:04 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Shradha Gupta <shradhagupta@...ux.microsoft.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Wilczy�~Dski <kw@...ux.com>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Dexuan Cui <decui@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, 
	Haiyang Zhang <haiyangz@...rosoft.com>, "K. Y. Srinivasan" <kys@...rosoft.com>, 
	linux-hyperv@...r.kernel.org, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Nipun Gupta <nipun.gupta@....com>, Yury Norov <yury.norov@...il.com>, 
	Jason Gunthorpe <jgg@...pe.ca>, Jonathan Cameron <Jonathan.Cameron@...ei.com>, 
	Anna-Maria Behnsen <anna-maria@...utronix.de>, Kevin Tian <kevin.tian@...el.com>, 
	Long Li <longli@...rosoft.com>, Thomas Gleixner <tglx@...utronix.de>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Konstantin Taranov <kotaranov@...rosoft.com>, 
	Simon Horman <horms@...nel.org>, Leon Romanovsky <leon@...nel.org>, 
	Maxim Levitsky <mlevitsk@...hat.com>, Erni Sri Satya Vennela <ernis@...ux.microsoft.com>, 
	Peter Zijlstra <peterz@...radead.org>, netdev@...r.kernel.org, linux-rdma@...r.kernel.org, 
	Paul Rosswurm <paulros@...rosoft.com>, Shradha Gupta <shradhagupta@...rosoft.com>
Subject: Re: [PATCH v3 2/4] PCI: hv: Allow dynamic MSI-X vector allocation

On Fri, May 09, 2025 at 03:13:22AM -0700, Shradha Gupta wrote:
> Allow dynamic MSI-X vector allocation for pci_hyperv PCI controller
> by adding support for the flag MSI_FLAG_PCI_MSIX_ALLOC_DYN and using
> pci_msix_prepare_desc() to prepare the MSI-X descriptors.
> 
> Feature support added for both x86 and ARM64
> 
> Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
>  Changes in v3:
>  * Add arm64 support
> ---
>  Changes in v2:
>  * split the patch to keep changes in PCI and pci_hyperv controller
>    seperate
>  * replace strings "pci vectors" by "MSI-X vectors"
> ---
>  drivers/pci/controller/pci-hyperv.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index ac27bda5ba26..8c8882cb0ad2 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -598,7 +598,8 @@ static unsigned int hv_msi_get_int_vector(struct irq_data *data)
>  	return cfg->vector;
>  }
>  
> -#define hv_msi_prepare		pci_msi_prepare
> +#define hv_msi_prepare			pci_msi_prepare
> +#define hv_msix_prepare_desc		pci_msix_prepare_desc

Please do not use custom macro unless its defintion changes based on some
conditional. In this case, you should use pci_msix_prepare_desc directly for
prepare_desc() callback.

- Mani

--
மணிவண்ணன் சதாசிவம்