linux-kernel - Re: [PATCH net-next v2] net: Add support for providing the PTP hardware source in tsinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512101942.4a5b80a1@kmaincent-XPS-13-7390>
Date: Mon, 12 May 2025 10:19:42 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Donald Hunter <donald.hunter@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 Jason Xing <kernelxing@...cent.com>, Richard Cochran
 <richardcochran@...il.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, "Russell King (Oracle)"
 <linux@...linux.org.uk>
Subject: Re: [PATCH net-next v2] net: Add support for providing the PTP
 hardware source in tsinfo

On Thu, 8 May 2025 19:36:45 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Tue, 06 May 2025 14:18:45 +0200 Kory Maincent wrote:
> > +  -
> > +    name: ts-hwtstamp-source
> > +    enum-name: hwtstamp-source
> > +    header: linux/ethtool.h
> > +    type: enum
> > +    name-prefix: hwtstamp-source
> > +    entries: [ netdev, phylib ]  
> 
> You're missing value: 1, you should let YNL generate this to avoid
> the discrepancies.
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml
> b/Documentation/netlink/specs/ethtool.yaml index 20c6b2bf5def..3e2f470fb213
> 100644 --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -99,12 +99,21 @@ uapi-header: linux/ethtool_netlink_generated.h
>      type: enum
>      entries: [ unknown, disabled, enabled ]
>    -
> -    name: ts-hwtstamp-source
> -    enum-name: hwtstamp-source
> -    header: linux/ethtool.h
> +    name: hwtstamp-source
> +    name-prefix: hwtstamp-source-
>      type: enum
> -    name-prefix: hwtstamp-source

Should we keep the enum-name property as is is already use, or do you prefer to
rename all its use to ethtool-hwtstamp-source?

> -    entries: [ netdev, phylib ]
> +    entries:
> +      -
> +        name: netdev
> +        doc: |
> +          Hardware timestamp comes from a MAC or a device
> +          which has MAC and PHY integrated
> +        value: 1
> +      -
> +        name: phylib
> +        doc: |
> +          Hardware timestamp comes from one PHY device
> +          of the network topology

Oh ok, thanks for the pointers!

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com