linux-kernel - Re: [PATCH RFC md-6.16 v3 17/19] md/md-llbitmap: implement all bitmap operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cf0998f-6475-05d2-33a1-ebf3b3253b31@huaweicloud.com>
Date: Mon, 12 May 2025 16:28:22 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Christoph Hellwig <hch@....de>, Yu Kuai <yukuai1@...weicloud.com>
Cc: xni@...hat.com, colyli@...nel.org, agk@...hat.com, snitzer@...nel.org,
 mpatocka@...hat.com, song@...nel.org, linux-kernel@...r.kernel.org,
 dm-devel@...ts.linux.dev, linux-raid@...r.kernel.org, yi.zhang@...wei.com,
 yangerkun@...wei.com, johnny.chenyi@...wei.com,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH RFC md-6.16 v3 17/19] md/md-llbitmap: implement all bitmap
 operations

Hi,

在 2025/05/12 13:18, Christoph Hellwig 写道:
> On Mon, May 12, 2025 at 09:19:25AM +0800, Yu Kuai wrote:
>> And following APIs that are not needed:
>>   - llbitmap_write_all, used in old bitmap to mark all pages need
>>   writeback;
>>   - llbitmap_daemon_work, used in old bitmap, llbitmap use timer to
>>     trigger daemon;
>>   - llbitmap_cond_end_sync, use to end sync for completed sectors(TODO,
>>     don't affect functionality)
>> And following APIs that are not supported:
>>   - llbitmap_start_behind_write
>>   - llbitmap_end_behind_write
>>   - llbitmap_wait_behind_writes
>>   - llbitmap_sync_with_cluster
>>   - llbitmap_get_from_slot
>>   - llbitmap_copy_from_slot
>>   - llbitmap_set_pages
>>   - llbitmap_free
> 
> Please just make these optional instead of implementing stubs.

Ok, I'll add a patch to check if those methods are NULL before calling
them.

Thanks,
Kuai

> .
>