linux-kernel - Re: [PATCH] misc: ti_fpc202: Switch to of_fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47222064.fMDQidcC6G@fw-rgant>
Date: Mon, 12 May 2025 11:09:17 +0200
From: Romain Gantois <romain.gantois@...tlin.com>
To: wsa+renesas@...g-engineering.com,
 "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: linux-kernel@...r.kernel.org, "Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
 Arnd Bergmann <arnd@...db.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] misc: ti_fpc202: Switch to of_fwnode_handle()

Hello Jiri,

On Monday, 12 May 2025 10:58:52 CEST Jiri Slaby (SUSE) wrote:
> of_node_to_fwnode() is an irqdomain's reimplementation of the
> "officially" defined of_fwnode_handle(). The former is in the process of
> being removed, so use the latter instead.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver")
> Cc: Romain Gantois <romain.gantois@...tlin.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  drivers/misc/ti_fpc202.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c
> index b9c9ee4bfc4e..cc597682b89c 100644
> --- a/drivers/misc/ti_fpc202.c
> +++ b/drivers/misc/ti_fpc202.c
> @@ -284,7 +284,7 @@ static int fpc202_probe_port(struct fpc202_priv *priv,
> struct device_node *i2c_h
> 
>  	desc.chan_id = port_id;
>  	desc.parent = dev;
> -	desc.bus_handle = of_node_to_fwnode(i2c_handle);
> +	desc.bus_handle = of_fwnode_handle(i2c_handle);
>  	desc.num_aliases = FPC202_ALIASES_PER_PORT;
> 
>  	fpc202_fill_alias_table(priv->client, aliases, port_id);

Looks good to me.

Reviewed-by: Romain Gantois <romain.gantois@...tlin.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)