linux-kernel - Re: [PATCH v4 2/5] dt-bindings: PCI: qcom: Document the QCS615 PCIe Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02819d6c-a030-4987-bfcf-1d1a60ec3f00@kernel.org>
Date: Mon, 12 May 2025 11:26:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ziyue Zhang <quic_ziyuzhan@...cinc.com>
Cc: vkoul@...nel.org, kishon@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, dmitry.baryshkov@...aro.org, neil.armstrong@...aro.org,
 abel.vesa@...aro.org, manivannan.sadhasivam@...aro.org,
 lpieralisi@...nel.org, kw@...ux.com, bhelgaas@...gle.com,
 andersson@...nel.org, konradybcio@...nel.org, linux-phy@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
 quic_qianyu@...cinc.com, quic_krichai@...cinc.com, quic_vbadigan@...cinc.com
Subject: Re: [PATCH v4 2/5] dt-bindings: PCI: qcom: Document the QCS615 PCIe
 Controller

On 12/05/2025 10:16, Ziyue Zhang wrote:
> 
> On 5/7/2025 1:17 PM, Krzysztof Kozlowski wrote:
>> On Wed, May 07, 2025 at 11:15:56AM GMT, Ziyue Zhang wrote:
>>> From: Krishna chaitanya chundru <quic_krichai@...cinc.com>
>>>
>>> Add dedicated schema for the PCIe controllers found on QCS615.
>>> Due to qcs615's clock-names do not match any of the existing
>>> dt-bindings, a new compatible for qcs615 is needed.
>> Other bindings for QCS615 were not finished, so I have doubts this is
>> done as well. Send your bindings once you finish them.
>>
>> ...
>>
>>> +properties:
>>> +  compatible:
>>> +    const: qcom,qcs615-pcie
>>> +
>>> +  reg:
>>> +    minItems: 6
>>> +    maxItems: 6
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: parf # Qualcomm specific registers
>>> +      - const: dbi # DesignWare PCIe registers
>>> +      - const: elbi # External local bus interface registers
>>> +      - const: atu # ATU address space
>>> +      - const: config # PCIe configuration space
>>> +      - const: mhi # MHI registers
>>> +
>>> +  clocks:
>>> +    minItems: 5
>> Drop or use correct value - 6. I don't understand why this changed and
>> nothing in changelog explains this.
>>
>> Best regards,
>> Krzysztof
> 
> Hi Krzysztof
> 
> As discussed in qcs8300, gcc_aux_clk is recommended to be removed from PCIe PHY
> device tree node, so I need to update the bindings.

I don't see how this is relevant to the code you posted and to my
comment, so comment stays valid.

Best regards,
Krzysztof