linux-kernel - Re: [PATCH 01/10] rust: Rename timer_container_of() to hrtimer_container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87jz6mnpnm.fsf@kernel.org>
Date: Mon, 12 May 2025 11:29:01 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Ingo Molnar" <mingo@...nel.org>
Cc: <linux-kernel@...r.kernel.org>,  "Thomas Gleixner" <tglx@...utronix.de>,
  "Frederic Weisbecker" <frederic@...nel.org>,  "H . Peter Anvin"
 <hpa@...or.com>,  "Linus Torvalds" <torvalds@...ux-foundation.org>,
  "Peter Zijlstra" <peterz@...radead.org>,  "Miguel Ojeda"
 <ojeda@...nel.org>,  "Alex Gaynor" <alex.gaynor@...il.com>,  "Anna-Maria
 Behnsen" <anna-maria@...utronix.de>,  "Boqun Feng" <boqun.feng@...il.com>,
  "Lyude Paul" <lyude@...hat.com>,  "Rust ML"
 <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH 01/10] rust: Rename timer_container_of() to
 hrtimer_container_of()

"Ingo Molnar" <mingo@...nel.org> writes:

> * Andreas Hindborg <a.hindborg@...nel.org> wrote:
>
>> "Ingo Molnar" <mingo@...nel.org> writes:
>>
>> > This primitive is dealing with 'struct hrtimer' objects, not
>> > 'struct timer_list' objects - so clarify the name.
>> >
>> > We want to introduce the timer_container_of() symbol in the kernel
>> > for timer_list, make sure there's no clash of namespaces, at least
>> > on the conceptual plane.
>>
>> Is this a resend?
>
> I noted the changes in the boilerplate:
>
>   Changes in -v3:
>
>     - Picked up review tags
>     - Rebased to v6.15-rc5
>
> This particular patch didn't change.

Thanks. I didn't get the cover letter, but I should have looked for it.

>
>> Again, I think this change is unnecessary. Please see my earlier reply [1].
>>
>> Best regards,
>> Andreas Hindborg
>>
>>
>> [1] https://lore.kernel.org/all/877c3cbdq2.fsf@kernel.org
>
> Yeah, saw that, but you said you are fine with it if I insist, and I'd
> like to have this to free up the timer_* namespace.

Yes. I did not hear any proper insisting till now though.

> Since I think we'd
> like to introduce the timer_container_of() in the future it would be
> nice to do this rename, as:
>
> 	$ git grep -w timer_container_of
>
> will have hrtimer related false positive hits in rust/ code, even
> though the namespaces are obviously independent.

Ok, I see. I'm not used to grepping like that, but I see how that can be
annoying.

>
> The Rust method is arguably a minor misnomer as well: you have
> work_container_of around struct work, but timer_container_of is around
> struct hrtimer?

Yes, you are right.

Feel free to take this through tip. Otherwise maybe Miguel can pick it
up in the rust PR for 6.15.

Acked-by: Andreas Hindborg <a.hindborg@...nel.org>

Best regards,
Andreas Hindborg