linux-kernel - Re: [PATCH] lpfc: use memcpy for bios version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5da12dbf-4f18-44f7-9817-5e0dc70bddce@flourine.local>
Date: Mon, 12 May 2025 13:07:52 +0200
From: Daniel Wagner <dwagner@...e.de>
To: David Laight <david.laight.linux@...il.com>
Cc: Daniel Wagner <wagi@...nel.org>, 
	James Smart <james.smart@...adcom.com>, Dick Kennedy <dick.kennedy@...adcom.com>, 
	"James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lpfc: use memcpy for bios version

On Mon, Apr 14, 2025 at 09:51:09AM +0200, Daniel Wagner wrote:
> On Sun, Apr 13, 2025 at 07:02:38PM +0100, David Laight wrote:
> > On Wed, 09 Apr 2025 13:34:22 +0200
> > Daniel Wagner <wagi@...nel.org> wrote:
> > 
> > > The strlcat with FORTIFY support is triggering a panic because it thinks
> > > the target buffer will overflow although the correct target buffer
> > > size is passed in.
> 
> BTW, still trying to figure out what is happening here. It was observed
> on ppc64el but so far creating a crash dump is not working.

FTR, finally got hold on the crash dump. As expected, the problem is
that bios_ver_str is not properly NUL terminated. strlcat expects that
both input strings are properly terminated.