linux-kernel - Re: [PATCH net v2] net: cadence: macb: Fix a possible deadlock in macb_halt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250512111506.GA3339421@horms.kernel.org>
Date: Mon, 12 May 2025 12:15:06 +0100
From: Simon Horman <horms@...nel.org>
To: Mathieu Othacehe <othacehe@....org>
Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	anton.reding@...disgyr.com
Subject: Re: [PATCH net v2] net: cadence: macb: Fix a possible deadlock in
 macb_halt_tx.

On Fri, May 09, 2025 at 02:19:35PM +0200, Mathieu Othacehe wrote:
> There is a situation where after THALT is set high, TGO stays high as
> well. Because jiffies are never updated, as we are in a context with
> interrupts disabled, we never exit that loop and have a deadlock.
> 
> That deadlock was noticed on a sama5d4 device that stayed locked for days.
> 
> Use retries instead of jiffies so that the timeout really works and we do
> not have a deadlock anymore.
> 
> Fixes: e86cd53afc590 ("net/macb: better manage tx errors")
> 
> Signed-off-by: Mathieu Othacehe <othacehe@....org>
> ---
> v2: Use read_poll_timeout_atomic and add a Fixes tag.

Reviewed-by: Simon Horman <horms@...nel.org>